Bug 222934

Summary: Adopt new NSURLSessionConfiguration SPI for connection cache configuration
Product: WebKit Reporter: Ben Nham <nham>
Component: New BugsAssignee: Ben Nham <nham>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, ggaren, koivisto, nham, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=222998
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch none

Ben Nham
Reported 2021-03-08 12:45:21 PST
Adopt new NSURLSessionConfiguration SPI for connection cache configuration
Attachments
Patch (9.22 KB, patch)
2021-03-08 12:55 PST, Ben Nham 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (9.29 KB, patch)
2021-03-08 13:26 PST, Ben Nham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ben Nham
Comment 1 2021-03-08 12:55:27 PST
Created attachment 422604 [details] Patch
Ben Nham
Comment 2 2021-03-08 13:26:40 PST
Created attachment 422611 [details] Patch
Radar WebKit Bug Importer
Comment 3 2021-03-09 08:41:46 PST
<rdar://problem/75218970>
Sam Weinig
Comment 4 2021-03-09 08:55:35 PST
Comment on attachment 422611 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422611&action=review > Source/WebCore/platform/network/cf/ResourceRequestCFNet.h:51 > + case 0: Does CFNetwork define these values in constants anywhere?
Ben Nham
Comment 5 2021-03-09 09:05:00 PST
(In reply to Sam Weinig from comment #4) > Comment on attachment 422611 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=422611&action=review > > > Source/WebCore/platform/network/cf/ResourceRequestCFNet.h:51 > > + case 0: > > Does CFNetwork define these values in constants anywhere? No, the user just assigns an arbitrary integer value in the range [0, _connectionCacheNumPriorityLevels) as they please. So basically this SPI allows us to map our five WebKit resource priority levels into five CFNetwork request priority levels. Previously we were mapping our five resource priority levels into four CFNetwork request priority levels to work around the bug described in https://bugs.webkit.org/show_bug.cgi?id=203423. Also note that this SPI only affects HTTP/1.1 requests. There is a separate path for setting HTTP/2 stream priorities that is actually an API which we already use elsewhere (-[NSURLSessionTask priority]).
Geoffrey Garen
Comment 6 2021-03-09 09:27:01 PST
Comment on attachment 422611 [details] Patch r=me
EWS
Comment 7 2021-03-09 11:08:41 PST
Committed r274161: <https://commits.webkit.org/r274161> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422611 [details].
Note You need to log in before you can comment on or make changes to this bug.