Bug 222925 – [Cocoa] Changes in WebInspectorUI's appearance don't propagate to .effectiveAppearance while docked

• Component: Web Inspector
• Status: RESOLVED FIXED

[Blaze Burg]

.

[Blaze Burg]

<rdar://71201454>

[Blaze Burg]

Created attachment 422594 [details]
Patch v1.0

[Devin Rousso]

Comment on attachment 422594 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=422594&action=review

r=me with one question/concern

> Source/WebKit/UIProcess/Inspector/mac/WebInspectorProxyMac.mm:862
> +    [m_inspectorViewController webView].appearance = platformAppearance;

Does this have any effect on the inspected page when Web Inspector is docked and the developer changes the Appearance setting in the General pane of the Settings Tab?

[Blaze Burg]

Comment on attachment 422594 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=422594&action=review

>> Source/WebKit/UIProcess/Inspector/mac/WebInspectorProxyMac.mm:862
>> +    [m_inspectorViewController webView].appearance = platformAppearance;
> 
> Does this have any effect on the inspected page when Web Inspector is docked and the developer changes the Appearance setting in the General pane of the Settings Tab?

It's just for the inspector WebView (m_inspectorPage). The inspected webView will follow the appearance of the client (i.e. Safari) until set otherwise.

[EWS]

Committed r274106: <https://commits.webkit.org/r274106>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422594 [details].