Bug 222901

Summary: [GStreamer][WebRTC] VideoEncoder still doesn't comply with WebKit style
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebRTCAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, eric.carlson, ews-watchlist, glenn, hta, jbedard, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Philippe Normand
Reported 2021-03-08 03:07:35 PST
Bug 218748 was incomplete, as it didn't update the file filter in the coding style checker.
Attachments
Patch (26.11 KB, patch)
2021-03-08 04:06 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (26.06 KB, patch)
2021-03-09 08:23 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2021-03-08 04:06:21 PST
Created attachment 422553 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2021-03-08 10:36:43 PST
Comment on attachment 422553 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422553&action=review > Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoder.cpp:65 > + SetupFunc setupEncoder, const char* bitratePropertyName, SetBitrateFunc setBitrate, const char* keyframeIntervalPropertyName) SetupFunc&& and SetBitrateFunc&&
Philippe Normand
Comment 3 2021-03-09 08:23:56 PST
Created attachment 422699 [details] Patch
EWS
Comment 4 2021-03-09 08:53:23 PST
Committed r274149: <https://commits.webkit.org/r274149> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422699 [details].
Radar WebKit Bug Importer
Comment 5 2021-03-09 08:54:25 PST
<rdar://problem/75219358>
Note You need to log in before you can comment on or make changes to this bug.