Bug 222901

Summary: [GStreamer][WebRTC] VideoEncoder still doesn't comply with WebKit style
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebRTCAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, eric.carlson, ews-watchlist, glenn, hta, jbedard, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Philippe Normand 2021-03-08 03:07:35 PST
Bug 218748 was incomplete, as it didn't update the file filter in the coding style checker.
Comment 1 Philippe Normand 2021-03-08 04:06:21 PST
Created attachment 422553 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2021-03-08 10:36:43 PST
Comment on attachment 422553 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422553&action=review

> Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoder.cpp:65
> +        SetupFunc setupEncoder, const char* bitratePropertyName, SetBitrateFunc setBitrate, const char* keyframeIntervalPropertyName)

SetupFunc&& and SetBitrateFunc&&
Comment 3 Philippe Normand 2021-03-09 08:23:56 PST
Created attachment 422699 [details]
Patch
Comment 4 EWS 2021-03-09 08:53:23 PST
Committed r274149: <https://commits.webkit.org/r274149>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422699 [details].
Comment 5 Radar WebKit Bug Importer 2021-03-09 08:54:25 PST
<rdar://problem/75219358>