Summary: | [GStreamer][WebRTC] VideoEncoder still doesn't comply with WebKit style | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||
Component: | WebRTC | Assignee: | Philippe Normand <pnormand> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | calvaris, eric.carlson, ews-watchlist, glenn, hta, jbedard, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Philippe Normand
2021-03-08 03:07:35 PST
Created attachment 422553 [details]
Patch
Comment on attachment 422553 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422553&action=review > Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoder.cpp:65 > + SetupFunc setupEncoder, const char* bitratePropertyName, SetBitrateFunc setBitrate, const char* keyframeIntervalPropertyName) SetupFunc&& and SetBitrateFunc&& Created attachment 422699 [details]
Patch
Committed r274149: <https://commits.webkit.org/r274149> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422699 [details]. |