Bug 222859

Summary: Metal-ANGLE can ASSERT because MTL signal event code is compiled out
Product: WebKit Reporter: Dean Jackson <dino>
Component: WebGLAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, graouts, kbr, kkinnunen, kondapallykalyan, kpiddington, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kbr: review+

Dean Jackson
Reported 2021-03-06 05:54:55 PST
Metal-ANGLE can ASSERT because MTL signal event code is compiled out
Attachments
Patch (3.11 KB, patch)
2021-03-06 06:02 PST, Dean Jackson 		kbr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-06 05:56:33 PST
<rdar://problem/75132180>
Dean Jackson
Comment 2 2021-03-06 06:02:31 PST
Created attachment 422487 [details] Patch
EWS Watchlist
Comment 3 2021-03-08 04:26:08 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Kenneth Russell
Comment 4 2021-03-08 16:50:08 PST
Comment on attachment 422487 [details] Patch Looks good. I vaguely remember this fix being done elsewhere (in the previous attempt to upstream the new Metal backend to ANGLE?) but sounds fine to get this fix in now. r+
Dean Jackson
Comment 5 2021-03-17 13:34:26 PDT
Landed as part of r274547
Dean Jackson
Comment 6 2021-03-18 12:07:54 PDT
Committed r274660 (235485@main): <https://commits.webkit.org/235485@main>
Note You need to log in before you can comment on or make changes to this bug.