Bug 222857

Summary: [perf dashboard] Modernize MeasurementSet
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: dewei_zhu, saam, webkit-bug-importer, ysuzuki, zhifei_fang
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup dewei_zhu: review+

Description Ryosuke Niwa 2021-03-06 02:23:08 PST 
Modernize MeasurementSet.
Comment 1 Ryosuke Niwa 2021-03-06 02:36:22 PST 
Created attachment 422480 [details]
Cleanup
Comment 2 dewei_zhu 2021-03-06 15:46:11 PST 
Comment on attachment 422480 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=422480&action=review

> Websites/perf.webkit.org/public/v3/models/measurement-set.js:103
> +        let suffix = clusterEndTime ? '-' + +clusterEndTime : '';

Use `const`?
Comment 3 dewei_zhu 2021-03-06 15:46:21 PST 
r=me
Comment 4 Ryosuke Niwa 2021-03-06 16:08:11 PST 
(In reply to dewei_zhu from comment #2)
> Comment on attachment 422480 [details]
> Cleanup
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=422480&action=review
> 
> > Websites/perf.webkit.org/public/v3/models/measurement-set.js:103
> > +        let suffix = clusterEndTime ? '-' + +clusterEndTime : '';
> 
> Use `const`?

Good point!
Comment 5 Ryosuke Niwa 2021-03-06 16:25:03 PST 
Committed r274043 (234979@main): <https://commits.webkit.org/234979@main>
Comment 6 Radar WebKit Bug Importer 2021-03-06 16:26:14 PST 
<rdar://problem/75137842>