Bug 222857

Summary: [perf dashboard] Modernize MeasurementSet
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: dewei_zhu, saam, webkit-bug-importer, ysuzuki, zhifei_fang
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup dewei_zhu: review+

Ryosuke Niwa
Reported 2021-03-06 02:23:08 PST
Modernize MeasurementSet.
Attachments
Cleanup (23.54 KB, patch)
2021-03-06 02:36 PST, Ryosuke Niwa 		dewei_zhu: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2021-03-06 02:36:22 PST
Created attachment 422480 [details] Cleanup
dewei_zhu
Comment 2 2021-03-06 15:46:11 PST
Comment on attachment 422480 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=422480&action=review > Websites/perf.webkit.org/public/v3/models/measurement-set.js:103 > + let suffix = clusterEndTime ? '-' + +clusterEndTime : ''; Use `const`?
dewei_zhu
Comment 3 2021-03-06 15:46:21 PST
r=me
Ryosuke Niwa
Comment 4 2021-03-06 16:08:11 PST
(In reply to dewei_zhu from comment #2) > Comment on attachment 422480 [details] > Cleanup > > View in context: > https://bugs.webkit.org/attachment.cgi?id=422480&action=review > > > Websites/perf.webkit.org/public/v3/models/measurement-set.js:103 > > + let suffix = clusterEndTime ? '-' + +clusterEndTime : ''; > > Use `const`? Good point!
Ryosuke Niwa
Comment 5 2021-03-06 16:25:03 PST
Committed r274043 (234979@main): <https://commits.webkit.org/234979@main>
Radar WebKit Bug Importer
Comment 6 2021-03-06 16:26:14 PST
<rdar://problem/75137842>
Note You need to log in before you can comment on or make changes to this bug.