Bug 222835

Summary: [GPUP] Enable 2D Canvas in layout tests by default
Product: WebKit Reporter: Jon Lee <jonlee>
Component: CanvasAssignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, clopez, commit-queue, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, hi, sabouhallawa, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=webglgpup
Bug Depends on: 222855, 222879, 222880, 222881, 222960, 223004, 223096, 223176    
Bug Blocks:    
Attachments:
Description Flags
EWS test
none
Patch
none
Patch
simon.fraser: review+
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Description Jon Lee 2021-03-05 15:24:46 PST 
[GPUP] Enable 2D Canvas in layout tests by default
Comment 1 Jon Lee 2021-03-05 15:25:20 PST 
rdar://75048088
Comment 2 Jon Lee 2021-03-05 15:28:16 PST 
Created attachment 422438 [details]
EWS test
Comment 3 Said Abou-Hallawa 2021-03-06 01:02:50 PST 
Created attachment 422476 [details]
Patch
Comment 4 Said Abou-Hallawa 2021-03-06 03:38:36 PST 
Created attachment 422483 [details]
Patch
Comment 5 Simon Fraser (smfr) 2021-03-06 20:58:48 PST 
Comment on attachment 422483 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422483&action=review

> LayoutTests/ChangeLog:16
> +        * http/tests/canvas/color-fonts/fill-gradient-sbix-2.html:
> +        * http/tests/canvas/color-fonts/fill-gradient-sbix-3.html:
> +        * http/tests/canvas/color-fonts/fill-gradient-sbix-4.html:
> +        * http/tests/canvas/color-fonts/stroke-gradient-sbix-2.html:
> +        * http/tests/canvas/color-fonts/stroke-gradient-sbix-3.html:
> +        * http/tests/canvas/color-fonts/stroke-gradient-sbix-4.html:
> +        * inspector/canvas/memory.html:
> +        * svg/canvas/canvas-global-alpha-svg.html:

Would be nice to annotate these with bug numbers to explain why they still fail.
Comment 6 Said Abou-Hallawa 2021-03-07 01:08:27 PST 
Created attachment 422521 [details]
Patch
Comment 7 Said Abou-Hallawa 2021-03-08 12:57:36 PST 
Created attachment 422605 [details]
Patch
Comment 8 Said Abou-Hallawa 2021-03-08 13:01:52 PST 
Created attachment 422606 [details]
Patch
Comment 9 EWS Watchlist 2021-03-08 13:02:40 PST 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 10 Simon Fraser (smfr) 2021-03-08 13:10:41 PST 
Comment on attachment 422606 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422606&action=review

> LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/line-styles/2d.line.cap.butt.html:1
> +<!-- webkit-test-runner [ UseGPUProcessForCanvasRenderingEnabled=false ] -->

Is this something we can do in WPT?
Comment 11 Said Abou-Hallawa 2021-03-08 13:26:04 PST 
Comment on attachment 422606 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422606&action=review

>> LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/line-styles/2d.line.cap.butt.html:1
>> +<!-- webkit-test-runner [ UseGPUProcessForCanvasRenderingEnabled=false ] -->
> 
> Is this something we can do in WPT?

It is a temporary change till the issue is investigated. The other choice is to skip the test on macOS and iOS.
Comment 12 Said Abou-Hallawa 2021-03-08 14:33:40 PST 
Created attachment 422620 [details]
Patch
Comment 13 Said Abou-Hallawa 2021-03-08 17:06:03 PST 
Created attachment 422641 [details]
Patch
Comment 14 Said Abou-Hallawa 2021-03-08 17:58:32 PST 
Created attachment 422647 [details]
Patch
Comment 15 Said Abou-Hallawa 2021-03-08 19:14:15 PST 
Created attachment 422654 [details]
Patch
Comment 16 Said Abou-Hallawa 2021-03-08 19:15:28 PST 
Created attachment 422655 [details]
Patch
Comment 17 Said Abou-Hallawa 2021-03-08 19:16:12 PST 
Created attachment 422656 [details]
Patch
Comment 18 Said Abou-Hallawa 2021-03-08 19:18:00 PST 
Created attachment 422657 [details]
Patch
Comment 19 Said Abou-Hallawa 2021-03-08 20:07:53 PST 
Created attachment 422660 [details]
Patch
Comment 20 Simon Fraser (smfr) 2021-03-08 20:12:44 PST 
Comment on attachment 422660 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422660&action=review

> Source/WebCore/html/ImageBitmap.cpp:848
> +    if (isMainThread())
> +        return;
> +    if (auto imageBuffer = takeImageBuffer())
> +        callOnMainThread([imageBuffer = WTFMove(imageBuffer)]() mutable { });

This should probably be done in a separate patch.
Comment 21 Said Abou-Hallawa 2021-03-09 00:51:26 PST 
Comment on attachment 422660 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422660&action=review

>> Source/WebCore/html/ImageBitmap.cpp:848
>> +        callOnMainThread([imageBuffer = WTFMove(imageBuffer)]() mutable { });
> 
> This should probably be done in a separate patch.

Done in bug 222960.
Comment 22 Said Abou-Hallawa 2021-03-09 12:15:45 PST 
Created attachment 422741 [details]
Patch
Comment 23 EWS 2021-03-09 13:19:35 PST 
Committed r274171: <https://commits.webkit.org/r274171>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422741 [details].
Comment 24 WebKit Commit Bot 2021-03-09 15:49:45 PST 
Re-opened since this is blocked by bug 223004
Comment 25 Said Abou-Hallawa 2021-03-11 22:01:52 PST 
Created attachment 423015 [details]
Patch
Comment 26 EWS 2021-03-11 22:57:49 PST 
Committed r274327: <https://commits.webkit.org/r274327>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423015 [details].