Bug 222827

Summary: [webkitscmpy] Add repository_id
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dewei_zhu, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2021-03-05 14:05:31 PST
Make webkitscmpy's representation of a commit compatible with what the results database uses.
Attachments
Patch (17.06 KB, patch)
2021-03-05 14:11 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (17.04 KB, patch)
2021-03-08 09:29 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-05 14:05:56 PST
<rdar://problem/75111000>
Jonathan Bedard
Comment 2 2021-03-05 14:11:28 PST
Created attachment 422418 [details] Patch
dewei_zhu
Comment 3 2021-03-05 17:20:57 PST
Comment on attachment 422418 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422418&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/scm_base.py:43 > + def __init__(self, dev_branches=None, prod_branches=None, contributors=None, id=None): Worth mention that id is a built-in, but seems a reasonable variable name here.
Jonathan Bedard
Comment 4 2021-03-08 09:15:00 PST
(In reply to dewei_zhu from comment #3) > Comment on attachment 422418 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=422418&action=review > > > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/scm_base.py:43 > > + def __init__(self, dev_branches=None, prod_branches=None, contributors=None, id=None): > > Worth mention that id is a built-in, but seems a reasonable variable name > here. Yes, I usually try to avoid using built-ins, but this seems like the right variable name.
Jonathan Bedard
Comment 5 2021-03-08 09:29:23 PST
Created attachment 422576 [details] Patch for landing
EWS
Comment 6 2021-03-08 10:09:36 PST
Committed r274080: <https://commits.webkit.org/r274080> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422576 [details].
Note You need to log in before you can comment on or make changes to this bug.