Bug 222810

Summary: [Payment Request] if `requestShipping: false` then we should not show any `PaymentShippingOption` in the Apple Pay sheet
Product: WebKit Reporter: Devin Rousso <hi>
Component: New BugsAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, hi, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+, hi: commit-queue-
Patch
hi: commit-queue+
Patch
none
Patch none

Devin Rousso
Reported 2021-03-05 10:48:33 PST
.
Attachments
Patch (3.10 KB, patch)
2021-03-05 10:54 PST, Devin Rousso 		thorton: review+
hi: commit-queue-
DetailsFormatted DiffDiff
Patch (2.29 KB, patch)
2021-03-05 12:43 PST, Devin Rousso 		hi: commit-queue+
DetailsFormatted DiffDiff
Patch (11.11 KB, patch)
2021-03-05 13:42 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (18.52 KB, patch)
2021-03-05 13:56 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2021-03-05 10:48:52 PST
<rdar://problem/74550889>
Devin Rousso
Comment 2 2021-03-05 10:54:04 PST
Created attachment 422384 [details] Patch
Devin Rousso
Comment 3 2021-03-05 12:11:06 PST
Comment on attachment 422384 [details] Patch After talking with @Andy Estes, I think I want/need to tweak this to be more spec compatible.
Devin Rousso
Comment 4 2021-03-05 12:43:43 PST
Created attachment 422396 [details] Patch
Devin Rousso
Comment 5 2021-03-05 13:42:46 PST
Created attachment 422408 [details] Patch
Devin Rousso
Comment 6 2021-03-05 13:56:59 PST
Created attachment 422413 [details] Patch
EWS
Comment 7 2021-03-05 15:29:07 PST
Committed r274012: <https://commits.webkit.org/r274012> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422413 [details].
Note You need to log in before you can comment on or make changes to this bug.