Bug 222796

Summary: Split WebXR features into enabledFeatures, supportedFeatures and requestedFeatures
Product: WebKit Reporter: Imanol Fernandez <ifernandez>
Component: WPE WebKitAssignee: Imanol Fernandez <ifernandez>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, svillar, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 208988    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Imanol Fernandez
Reported 2021-03-05 03:57:33 PST
Currently enabledFeatures array is used both for checking supported and enabled features. This is causing some tests to fail: e.g. Test that reference spaces that aren't default features are rejected when not requested as a feature.
Attachments
Patch (20.79 KB, patch)
2021-03-05 05:21 PST, Imanol Fernandez 		no flags
DetailsFormatted DiffDiff
Patch for landing (24.42 KB, patch)
2021-03-15 05:30 PDT, Imanol Fernandez 		no flags
DetailsFormatted DiffDiff
Patch for landing (24.36 KB, patch)
2021-03-15 05:33 PDT, Imanol Fernandez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Imanol Fernandez
Comment 1 2021-03-05 05:21:15 PST
Created attachment 422367 [details] Patch
Imanol Fernandez
Comment 2 2021-03-05 08:12:32 PST
Comment on attachment 422367 [details] Patch The spec was a bit confusing in the steps to check if a reference space is supported. I opened this related issue: https://github.com/immersive-web/webxr/issues/1178
Sergio Villar Senin
Comment 3 2021-03-15 04:11:13 PDT
Comment on attachment 422367 [details] Patch Awesome! Please do also consider renaming ListOfEnabledFeatures to some other thing like ListOfFeatures or FeatureList or the like as we're know dealing with different lists.
Imanol Fernandez
Comment 4 2021-03-15 05:30:45 PDT
Created attachment 423159 [details] Patch for landing
EWS
Comment 5 2021-03-15 05:31:13 PDT
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Imanol Fernandez
Comment 6 2021-03-15 05:33:39 PDT
Created attachment 423160 [details] Patch for landing
EWS
Comment 7 2021-03-15 06:00:41 PDT
Committed r274416: <https://commits.webkit.org/r274416> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423160 [details].
Note You need to log in before you can comment on or make changes to this bug.