Summary: | [WASM-Function-References] Update ref.func to produce (ref $t) | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dmitry <dbezhetskov> | ||||||||||
Component: | WebAssembly | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 247393 | ||||||||||||
Attachments: |
|
Description
Dmitry
2021-03-04 22:05:48 PST
Created attachment 422337 [details]
Patch
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json". Comment on attachment 422337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422337&action=review r=me with comments. > Source/JavaScriptCore/wasm/generateWasmOpsHeader.py:217 > + uint64_t index; Use SignatureIndex instead. Using SignatureIndex will create a cycle dependency: WasmSignature.h includes WasmOps.h that includes WasmSignature.h But I did the "forward declaration" of SignatureIndex in WasmOps.h so this should work well. Created attachment 422348 [details]
Patch
Created attachment 422354 [details]
Patch
Created attachment 422358 [details]
Patch
Comment on attachment 422358 [details]
Patch
r=me
Committed r273962: <https://commits.webkit.org/r273962> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422358 [details]. |