Bug 222779

Summary:

[WASM-Function-References] Update ref.func to produce (ref $t)

Product:

WebKit

Reporter:

Dmitry <dbezhetskov>

Component:

WebAssembly

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

247393

Attachments:

Description	Flags
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none

Dmitry

Reported 2021-03-04 22:05:48 PST

[WASM-Function-References] Update ref.func to produce (ref $t)

Attachments
Patch (25.64 KB, patch) 2021-03-04 22:11 PST, Dmitry	no flags	Details Formatted Diff Diff
Patch (25.64 KB, patch) 2021-03-05 01:14 PST, Dmitry	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (25.71 KB, patch) 2021-03-05 01:58 PST, Dmitry	no flags	Details Formatted Diff Diff
Patch (27.59 KB, patch) 2021-03-05 02:31 PST, Dmitry	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Dmitry

Comment 1 2021-03-04 22:11:28 PST

Created attachment 422337 [details] Patch

EWS Watchlist

Comment 2 2021-03-04 22:12:29 PST

This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".

Yusuke Suzuki

Comment 3 2021-03-05 00:52:19 PST

Comment on attachment 422337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422337&action=review r=me with comments. > Source/JavaScriptCore/wasm/generateWasmOpsHeader.py:217 > + uint64_t index; Use SignatureIndex instead.

Dmitry

Comment 4 2021-03-05 01:12:11 PST

Using SignatureIndex will create a cycle dependency: WasmSignature.h includes WasmOps.h that includes WasmSignature.h But I did the "forward declaration" of SignatureIndex in WasmOps.h so this should work well.

Dmitry

Comment 5 2021-03-05 01:14:30 PST

Created attachment 422348 [details] Patch

Dmitry

Comment 6 2021-03-05 01:58:27 PST

Created attachment 422354 [details] Patch

Dmitry

Comment 7 2021-03-05 02:31:42 PST

Created attachment 422358 [details] Patch

Yusuke Suzuki

Comment 8 2021-03-05 03:45:00 PST

Comment on attachment 422358 [details] Patch r=me