Bug 222771

Summary: [WinCairo] Builds with ENABLE_CONTEXT_MENUS=OFF fail
Product: WebKit Reporter: Stephan Szabo <stephan.szabo>
Component: WebKit Misc.Assignee: Stephan Szabo <stephan.szabo>
Status: RESOLVED FIXED    
Severity: Normal CC: don.olmstead, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch none

Stephan Szabo
Reported 2021-03-04 17:00:35 PST
While looking at a problem with a TestWebKit test that times out if ENABLE_CONTEXT_MENUS is off (on PlayStation), I noticed that there are a bunch of compilation errors trying to build WinCairo with the flag turned off which seems bad.
Attachments
Patch (6.43 KB, patch)
2021-03-08 10:13 PST, Stephan Szabo 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (6.43 KB, patch)
2021-03-08 10:28 PST, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Stephan Szabo
Comment 1 2021-03-08 10:13:33 PST
Created attachment 422580 [details] Patch
Stephan Szabo
Comment 2 2021-03-08 10:28:34 PST
Created attachment 422582 [details] Patch
EWS
Comment 3 2021-03-08 12:09:21 PST
Committed r274089: <https://commits.webkit.org/r274089> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422582 [details].
Radar WebKit Bug Importer
Comment 4 2021-03-08 12:10:16 PST
<rdar://problem/75181469>
Note You need to log in before you can comment on or make changes to this bug.