Bug 222732

Summary: AVAudioSessionCaptureDeviceManager::retrieveAudioSessionCaptureDevices is unnecessarily creating a NSArray twice
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing none

youenn fablet
Reported 2021-03-04 04:39:59 PST
AVAudioSessionCaptureDeviceManager::retrieveAudioSessionCaptureDevices is unnecessarily creating a NSArray twice
Attachments
Patch (2.49 KB, patch)
2021-03-04 04:44 PST, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (2.51 KB, patch)
2021-03-04 05:02 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.53 KB, patch)
2021-03-04 08:27 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-03-04 04:43:12 PST
<rdar://problem/74621795>
youenn fablet
Comment 2 2021-03-04 04:44:00 PST
Created attachment 422214 [details] Patch
youenn fablet
Comment 3 2021-03-04 05:02:43 PST
Created attachment 422215 [details] Patch
Eric Carlson
Comment 4 2021-03-04 05:47:49 PST
Comment on attachment 422215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422215&action=review > Source/WebCore/ChangeLog:8 > + Before the patch, [m_audioSession availableInputs]. Something is missing here
youenn fablet
Comment 5 2021-03-04 08:27:33 PST
Created attachment 422231 [details] Patch for landing
EWS
Comment 6 2021-03-04 09:49:27 PST
Committed r273894: <https://commits.webkit.org/r273894> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422231 [details].
Note You need to log in before you can comment on or make changes to this bug.