Bug 22273

Summary: CTI get/put arg methods are badly named
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
The patch ggaren: review+

Gavin Barraclough
Reported 2008-11-14 18:06:41 PST
emitGetArg and emitPutArg were not symmetric operations, and were accessing completely separate sets of data. Rename to something more sensible.
Attachments
The patch (97.66 KB, patch)
2008-11-14 18:07 PST, Gavin Barraclough 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2008-11-14 18:07:12 PST
Created attachment 25179 [details] The patch
Geoffrey Garen
Comment 2 2008-11-14 18:10:00 PST
Comment on attachment 25179 [details] The patch excellent! r=me
Gavin Barraclough
Comment 3 2008-11-14 18:57:58 PST
Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/VM/CTI.cpp Sending JavaScriptCore/VM/CTI.h Transmitting file data ... Committed revision 38414.
Note You need to log in before you can comment on or make changes to this bug.