Bug 22271

Summary: Default pixel test tolerance should be non-zero
Product: WebKit Reporter: Pierre-Olivier Latour <pol>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 22323    
Attachments:
Description Flags
Patch v1
none
Patch v2 mjs: review+

Pierre-Olivier Latour
Reported 2008-11-14 14:11:26 PST
After discussing on IRC, it seems consensus is to have default pixel test tolerance be non-zero: - Leopard: 0.1% - Tiger: 1.0%
Attachments
Patch v1 (2.35 KB, patch)
2008-11-14 14:39 PST, Pierre-Olivier Latour 		no flags
DetailsFormatted DiffDiff
Patch v2 (2.36 KB, patch)
2008-11-14 14:40 PST, Pierre-Olivier Latour 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pierre-Olivier Latour
Comment 1 2008-11-14 14:39:07 PST
Created attachment 25176 [details] Patch v1
Pierre-Olivier Latour
Comment 2 2008-11-14 14:40:10 PST
Created attachment 25177 [details] Patch v2
Maciej Stachowiak
Comment 3 2008-11-14 14:42:25 PST
Comment on attachment 25177 [details] Patch v2 r=me
Dean Jackson
Comment 4 2008-11-17 14:11:16 PST
Committed r38527 M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests
Note You need to log in before you can comment on or make changes to this bug.