Bug 222704 – [LFC][IFC] Make LineBox::m_inlineLevelBoxRectMap a non-root inline level box map

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

root inline box does not need to go in there.

[zalan]

Created attachment 422174 [details]
Patch

[Antti Koivisto]

Comment on attachment 422174 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422174&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBox.cpp:92
> -    m_inlineLevelBoxRectMap.reserveInitialCapacity(numberOfRuns);
> -    m_inlineLevelBoxRectMap.set(&rootLayoutBox, &m_rootInlineBox);
> +    m_nonRootInlineLevelBoxMap.reserveInitialCapacity(numberOfRuns);

Does it need one less capacity now?

[EWS]

Committed r273887: <https://commits.webkit.org/r273887>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422174 [details].

[Radar WebKit Bug Importer]

<rdar://problem/75033710>

[zalan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 422174 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=422174&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineLineBox.cpp:92
> > -    m_inlineLevelBoxRectMap.reserveInitialCapacity(numberOfRuns);
> > -    m_inlineLevelBoxRectMap.set(&rootLayoutBox, &m_rootInlineBox);
> > +    m_nonRootInlineLevelBoxMap.reserveInitialCapacity(numberOfRuns);
> 
> Does it need one less capacity now?
yeah I was going to talk to you about it. we need a better approximation for this.