Summary: | [build.webkit.org] run buildbot checkconfig in services ews | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aakash_jain, ap, jbedard, ryanhaddad, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Aakash Jain
2021-03-03 14:15:43 PST
Created attachment 422608 [details]
Patch
Created attachment 423063 [details]
Patch
Sample run: https://ews-build.webkit-uat.org/#/builders/1/builds/1497 (see step 11 and 13). Comment on attachment 423063 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423063&action=review > Tools/CISupport/ews-build/steps.py:1259 > + directory = 'build/Tools/CISupport/ews-build' Why is this in the shared class? Comment on attachment 423063 [details]
Patch
r=me, seems like the directory may be there to make the linter happy, but I would make the directory something that makes this fact more clear
(In reply to Jonathan Bedard from comment #6) > Why is this in the shared class? No strong reason. Wanted to keep this as a valid step as well (in case anyone uses this as a build step directly for some reason in future). commit-queue failed to commit attachment 423063 [details] to WebKit repository. To retry, please set cq+ flag again.
commit-queue failed to commit attachment 423063 [details] to WebKit repository. To retry, please set cq+ flag again.
commit-queue failed to commit attachment 423063 [details] to WebKit repository. To retry, please set cq+ flag again.
Committed r274388: <https://commits.webkit.org/r274388> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423063 [details]. |