Bug 222648

Summary: [JSC] Simplify OSRExit side state materialization
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, ticaiolima, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Yusuke Suzuki
Reported 2021-03-03 03:43:41 PST
[JSC] Simplify OSRExit side state materialization
Attachments
Patch (39.54 KB, patch)
2021-03-03 03:50 PST, Yusuke Suzuki 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (39.54 KB, patch)
2021-03-03 03:57 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (39.89 KB, patch)
2021-03-03 04:11 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (39.73 KB, patch)
2021-03-03 04:18 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (39.75 KB, patch)
2021-03-03 04:31 PST, Yusuke Suzuki 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (39.78 KB, patch)
2021-03-03 04:38 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (38.91 KB, patch)
2021-03-03 05:14 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (38.95 KB, patch)
2021-03-05 12:50 PST, Yusuke Suzuki 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (38.95 KB, patch)
2021-03-05 13:04 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-03-03 03:50:38 PST
Created attachment 422057 [details] Patch
Yusuke Suzuki
Comment 2 2021-03-03 03:57:05 PST
Created attachment 422061 [details] Patch
Yusuke Suzuki
Comment 3 2021-03-03 04:11:53 PST
Created attachment 422062 [details] Patch
Yusuke Suzuki
Comment 4 2021-03-03 04:18:50 PST
Created attachment 422063 [details] Patch
Yusuke Suzuki
Comment 5 2021-03-03 04:31:18 PST
Created attachment 422064 [details] Patch
Yusuke Suzuki
Comment 6 2021-03-03 04:38:19 PST
Created attachment 422065 [details] Patch
Yusuke Suzuki
Comment 7 2021-03-03 05:14:27 PST
Created attachment 422069 [details] Patch
Caio Lima
Comment 8 2021-03-05 06:39:44 PST
Comment on attachment 422069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422069&action=review I tested the patch locally with 2 changes below, and it passes tests. > Source/JavaScriptCore/dfg/DFGOSRExit.cpp:636 > +#if USE(JSVALUE64_32) It should be `#if USE(JSVALUE64_32)` > Source/JavaScriptCore/dfg/DFGOSRExit.cpp:659 > + break Missing '''
Caio Lima
Comment 9 2021-03-05 06:46:08 PST
Comment on attachment 422069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422069&action=review Patch LGTM. Informal r+. It also fixes support for double on `CheckpointOSRExitSideState`! >> Source/JavaScriptCore/dfg/DFGOSRExit.cpp:636 >> +#if USE(JSVALUE64_32) > > It should be `#if USE(JSVALUE64_32)` I meant `#if USE(JSVALUE32_64)`
Yusuke Suzuki
Comment 10 2021-03-05 12:50:42 PST
Created attachment 422398 [details] Patch
Yusuke Suzuki
Comment 11 2021-03-05 13:04:38 PST
Created attachment 422400 [details] Patch
Keith Miller
Comment 12 2021-03-05 15:36:51 PST
Comment on attachment 422400 [details] Patch I didn't know probe leaked memory... r=me.
EWS
Comment 13 2021-03-05 18:25:53 PST
Committed r274024: <https://commits.webkit.org/r274024> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422400 [details].
Radar WebKit Bug Importer
Comment 14 2021-03-05 18:26:15 PST
<rdar://problem/75122234>
Note You need to log in before you can comment on or make changes to this bug.