Bug 222648

Summary: [JSC] Simplify OSRExit side state materialization
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, ticaiolima, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Description Yusuke Suzuki 2021-03-03 03:43:41 PST 
[JSC] Simplify OSRExit side state materialization
Comment 1 Yusuke Suzuki 2021-03-03 03:50:38 PST 
Created attachment 422057 [details]
Patch
Comment 2 Yusuke Suzuki 2021-03-03 03:57:05 PST 
Created attachment 422061 [details]
Patch
Comment 3 Yusuke Suzuki 2021-03-03 04:11:53 PST 
Created attachment 422062 [details]
Patch
Comment 4 Yusuke Suzuki 2021-03-03 04:18:50 PST 
Created attachment 422063 [details]
Patch
Comment 5 Yusuke Suzuki 2021-03-03 04:31:18 PST 
Created attachment 422064 [details]
Patch
Comment 6 Yusuke Suzuki 2021-03-03 04:38:19 PST 
Created attachment 422065 [details]
Patch
Comment 7 Yusuke Suzuki 2021-03-03 05:14:27 PST 
Created attachment 422069 [details]
Patch
Comment 8 Caio Lima 2021-03-05 06:39:44 PST 
Comment on attachment 422069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422069&action=review

I tested the patch locally with 2 changes below, and it passes tests.

> Source/JavaScriptCore/dfg/DFGOSRExit.cpp:636
> +#if USE(JSVALUE64_32)

It should be `#if USE(JSVALUE64_32)`

> Source/JavaScriptCore/dfg/DFGOSRExit.cpp:659
> +            break

Missing '''
Comment 9 Caio Lima 2021-03-05 06:46:08 PST 
Comment on attachment 422069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422069&action=review

Patch LGTM. Informal r+. It also fixes support for double on `CheckpointOSRExitSideState`!

>> Source/JavaScriptCore/dfg/DFGOSRExit.cpp:636
>> +#if USE(JSVALUE64_32)
> 
> It should be `#if USE(JSVALUE64_32)`

I meant `#if USE(JSVALUE32_64)`
Comment 10 Yusuke Suzuki 2021-03-05 12:50:42 PST 
Created attachment 422398 [details]
Patch
Comment 11 Yusuke Suzuki 2021-03-05 13:04:38 PST 
Created attachment 422400 [details]
Patch
Comment 12 Keith Miller 2021-03-05 15:36:51 PST 
Comment on attachment 422400 [details]
Patch

I didn't know probe leaked memory...

r=me.
Comment 13 EWS 2021-03-05 18:25:53 PST 
Committed r274024: <https://commits.webkit.org/r274024>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422400 [details].
Comment 14 Radar WebKit Bug Importer 2021-03-05 18:26:15 PST 
<rdar://problem/75122234>