Bug 222600

Summary:

[build.webkit.org] Rename master_buildbot2.cfg to master.cfg

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, darin, dewei_zhu, jbedard, slewis, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
[fast-cq] Patch	none

Aakash Jain

Reported 2021-03-02 08:21:26 PST

master_buildbot2.cfg was created for buildbot 2 instance (see https://bugs.webkit.org/show_bug.cgi?id=218102#c0), as at that time master.cfg was used for old buildbot. Now that we have fully switched to new buildbot, and have deleted master.cfg for old buildbot, we should rename master_buildbot2.cfg to master.cfg

Attachments
Patch (6.62 KB, patch) 2021-05-07 14:04 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
[fast-cq] Patch (7.16 KB, patch) 2021-05-07 14:26 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-03-09 08:22:15 PST

<rdar://problem/75218344>

Aakash Jain

Comment 2 2021-05-07 14:04:10 PDT Comment hidden (obsolete)

Created attachment 428030 [details] Patch

Aakash Jain

Comment 3 2021-05-07 14:26:00 PDT

Created attachment 428035 [details] [fast-cq] Patch

Darin Adler

Comment 4 2021-05-08 21:08:20 PDT

Comment on attachment 428035 [details] [fast-cq] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428035&action=review > Tools/ChangeLog:3 > + [build.webkit.org] Rename master_buildbot2.cfg to master.cfg Seems fine, but you don’t say *why*

Aakash Jain

Comment 5 2021-05-10 08:36:15 PDT

(In reply to Darin Adler from comment #4) > Seems fine, but you don’t say *why* Simply because that's the default name used by buildbot (e.g.: https://github.com/buildbot/buildbot/blob/master/master/buildbot/master.py#L88), and for consistency with our other buildbot configurations (they also use master.cfg file name).

EWS

Comment 6 2021-05-10 11:10:59 PDT

Committed r277275 (237542@main): <https://commits.webkit.org/237542@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428035 [details].

Darin Adler

Comment 7 2021-05-10 12:18:08 PDT

(In reply to Aakash Jain from comment #5) > (In reply to Darin Adler from comment #4) > > Seems fine, but you don’t say *why* > Simply because that's the default name used by buildbot (e.g.: > https://github.com/buildbot/buildbot/blob/master/master/buildbot/master. > py#L88), and for consistency with our other buildbot configurations (they > also use master.cfg file name). We should say such things in change logs. The most important question to answer in any change log is "why".

Aakash Jain

Comment 8 2021-05-12 07:09:17 PDT

(In reply to Darin Adler from comment #7) > We should say such things in change logs. The most important question to answer in any change log is "why". ok. Will keep that in mind in future.

Note You need to log in before you can comment on or make changes to this bug.