Bug 222570

Summary: [GPUP] Clean up LayoutTests/gpu-process/TestExpectations related to media tests
Product: WebKit Reporter: Peng Liu <peng.liu6>
Component: MediaAssignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, jer.noble, jonlee, rini_patel, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Revise the patch based on Jon's comments none

Peng Liu
Reported 2021-03-01 11:51:24 PST
[GPUP] Clean up LayoutTests/gpu-process/TestExpectations related to media tests
Attachments
Patch (5.57 KB, patch)
2021-03-01 12:00 PST, Peng Liu 		no flags
DetailsFormatted DiffDiff
Revise the patch based on Jon's comments (5.59 KB, patch)
2021-03-01 13:10 PST, Peng Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peng Liu
Comment 1 2021-03-01 12:00:07 PST
Created attachment 421854 [details] Patch
Jon Lee
Comment 2 2021-03-01 12:55:30 PST
Comment on attachment 421854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421854&action=review > LayoutTests/platform/wk2/TestExpectations:306 > +fast/images/animated-image-mp4-crash.html [ Timeout ] results.webkit.org doesn't seem to show any timeouts for this test. > LayoutTests/platform/wk2/TestExpectations:322 > +imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_loadeddata.html [ Crash Pass ] All three of these appear to only be flaky crashing on WK2 debug bots.
Peng Liu
Comment 3 2021-03-01 12:56:53 PST
Comment on attachment 421854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421854&action=review >> LayoutTests/platform/wk2/TestExpectations:306 >> +fast/images/animated-image-mp4-crash.html [ Timeout ] > > results.webkit.org doesn't seem to show any timeouts for this test. I can reproduce the issue locally with stress tests.
Peng Liu
Comment 4 2021-03-01 13:01:26 PST
Comment on attachment 421854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421854&action=review >> LayoutTests/platform/wk2/TestExpectations:322 >> +imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_loadeddata.html [ Crash Pass ] > > All three of these appear to only be flaky crashing on WK2 debug bots. Right. They are assertion failures.
Jon Lee
Comment 5 2021-03-01 13:02:56 PST
Comment on attachment 421854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421854&action=review >>> LayoutTests/platform/wk2/TestExpectations:322 >>> +imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_loadeddata.html [ Crash Pass ] >> >> All three of these appear to only be flaky crashing on WK2 debug bots. > > Right. They are assertion failures. Then shouldn't these be annotated with [ Debug ]?
Peng Liu
Comment 6 2021-03-01 13:10:25 PST
Created attachment 421858 [details] Revise the patch based on Jon's comments
Peng Liu
Comment 7 2021-03-01 13:11:11 PST
Comment on attachment 421854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421854&action=review >>>> LayoutTests/platform/wk2/TestExpectations:322 >>>> +imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_loadeddata.html [ Crash Pass ] >>> >>> All three of these appear to only be flaky crashing on WK2 debug bots. >> >> Right. They are assertion failures. > > Then shouldn't these be annotated with [ Debug ]? Correct. Fixed.
Eric Carlson
Comment 8 2021-03-01 14:40:09 PST
Comment on attachment 421858 [details] Revise the patch based on Jon's comments rs=me
EWS
Comment 9 2021-03-01 15:02:50 PST
commit-queue failed to commit attachment 421858 [details] to WebKit repository. To retry, please set cq+ flag again.
EWS
Comment 10 2021-03-01 15:11:09 PST
Committed r273696: <https://commits.webkit.org/r273696> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421858 [details].
Radar WebKit Bug Importer
Comment 11 2021-03-01 15:12:14 PST
<rdar://problem/74893907>
Note You need to log in before you can comment on or make changes to this bug.