Bug 22254 – Compiler warning for Page.cpp

• Component: New Bugs
• Status: RESOLVED INVALID

[Craig Schlenter]

I get this when compiling chromium which is running pretty much the latest webkit.

/home/craig/chromium/src/third_party/WebKit/WebCore/page/Page.h: In constructor
'WebCore::Page::Page(WebCore::ChromeClient*, WebCore::ContextMenuClient*,
WebCore::EditorClient*, WebCore::DragClient*, WebCore::InspectorClient*)':
/home/craig/chromium/src/third_party/WebKit/WebCore/page/Page.h:197: warning:
'WebCore::Page::m_inspectorController' will be initialized after
/home/craig/chromium/src/third_party/WebKit/WebCore/page/Page.h:192: warning:  
'WTF::OwnPtr<WebCore::Settings> WebCore::Page::m_settings'
/home/craig/chromium/src/third_party/WebKit/WebCore/page/Page.cpp:105: warning: 
 when initialized here

I have a patch to fix this but at the moment bugzilla isn't showing any "add attachment" options so I'm going to hit commit and hope that I can add the attachment afterwards ...

[Craig Schlenter]

Created attachment 25159 [details]
patch to fix compiler warning

uploaded patch .. set review:?

[Mark Rowe (bdash)]

Patches against Chromium's version of WebKit should be filed in Chromium's bug tracker.  This patch would *introduce* a warning if applied to tip of tree WebKit.

[Craig Schlenter]

Sorry!!! ... I had submitted this for inclusion in chrome and was told to submit webkit patches here but I didn't notice that Page.h is different in WebKit :( I'll try to check things more carefully in future.