Bug 222535

Summary: Support rotated image overlay text for non-rectilinear text quads
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cdumez, changseok, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, hi, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Add radar link
thorton: review+
Patch for landing none

Wenson Hsieh
Reported 2021-02-28 20:57:07 PST
Support rotated image overlay text for non-rectilinear text quads
Attachments
Patch (17.95 KB, patch)
2021-03-01 13:00 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Add radar link (18.03 KB, patch)
2021-03-01 14:49 PST, Wenson Hsieh 		thorton: review+
DetailsFormatted DiffDiff
Patch for landing (18.00 KB, patch)
2021-03-01 16:10 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2021-03-01 13:00:33 PST
Created attachment 421856 [details] Patch
Radar WebKit Bug Importer
Comment 2 2021-03-01 13:00:55 PST
<rdar://problem/74886200>
Wenson Hsieh
Comment 3 2021-03-01 14:49:44 PST
Created attachment 421869 [details] Add radar link
Tim Horton
Comment 4 2021-03-01 15:39:53 PST
Comment on attachment 421869 [details] Add radar link View in context: https://bugs.webkit.org/attachment.cgi?id=421869&action=review > Source/WebCore/platform/graphics/GeometryUtilities.h:65 > +struct RotatedRectInfo { "Info"? This is literally a rotated rectangle :)
Wenson Hsieh
Comment 5 2021-03-01 15:45:59 PST
Comment on attachment 421869 [details] Add radar link View in context: https://bugs.webkit.org/attachment.cgi?id=421869&action=review >> Source/WebCore/platform/graphics/GeometryUtilities.h:65 >> +struct RotatedRectInfo { > > "Info"? This is literally a rotated rectangle :) That's a good point — renamed to RotatedRect.
Wenson Hsieh
Comment 6 2021-03-01 16:10:13 PST
Created attachment 421883 [details] Patch for landing
EWS
Comment 7 2021-03-01 17:33:03 PST
Committed r273711: <https://commits.webkit.org/r273711> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421883 [details].
Note You need to log in before you can comment on or make changes to this bug.