Summary: | Restoring App Highlight crashes if no range is found. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||||
Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | info, thorton, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Megan Gardner
2021-02-27 23:23:05 PST
Created attachment 421766 [details]
Patch
Comment on attachment 421766 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421766&action=review > Source/WebCore/Modules/highlight/AppHighlightStorage.cpp:243 > + if (range) what is the bool return value of this method for? If it’s “did restoration succeed”, perhaps you should return false here? Created attachment 421831 [details]
Patch for landing
Committed r273654: <https://commits.webkit.org/r273654> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421831 [details]. im having same error with; > Source/WebCore/Modules/highlight/AppHighlightStorage.cpp:243 as seen at https://www.anneolmak.com/ |