Bug 222517

Summary: Add alternate, non-named-getter based, implementation of CSSStyleDeclaration back into WebCore
Product: WebKit Reporter: Sam Weinig <sam>
Component: BindingsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, cdumez, cmarcelo, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, joepeck, kondapallykalyan, macpherson, menard, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 217623    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
JSCSSStyleDeclaration.h (if you disable the legacy flag)
none
JSCSSStyleDeclaration.cpp (if you disable the legacy flag)
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Sam Weinig
Reported 2021-02-27 13:49:29 PST
To aid iteration on a good solution, let's re-land the non-named-getter based, implementation of CSSStyleDeclaration back into WebCore, but behind a compile time flag for now, to avoid the compile time and binary size regressions (see https://bugs.webkit.org/show_bug.cgi?id=217623). Once we improve remove the regressions, we can turn it on.
Attachments
Patch (53.22 KB, patch)
2021-02-27 14:05 PST, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
JSCSSStyleDeclaration.h (if you disable the legacy flag) (4.83 KB, text/x-csrc)
2021-02-27 14:06 PST, Sam Weinig 		no flags
Details
JSCSSStyleDeclaration.cpp (if you disable the legacy flag) (3.04 MB, text/x-csrc)
2021-02-27 14:06 PST, Sam Weinig 		no flags
Details
Patch (64.37 KB, patch)
2021-02-27 14:11 PST, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (64.37 KB, patch)
2021-02-27 14:48 PST, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (63.78 KB, patch)
2021-02-27 17:52 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (63.78 KB, patch)
2021-02-28 18:05 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2021-02-27 14:05:20 PST
Comment hidden (obsolete)
Sam Weinig
Comment 2 2021-02-27 14:06:12 PST
Created attachment 421756 [details] JSCSSStyleDeclaration.h (if you disable the legacy flag)
Sam Weinig
Comment 3 2021-02-27 14:06:37 PST
Created attachment 421757 [details] JSCSSStyleDeclaration.cpp (if you disable the legacy flag)
Sam Weinig
Comment 4 2021-02-27 14:11:23 PST
Comment hidden (obsolete)
Sam Weinig
Comment 5 2021-02-27 14:48:04 PST
Comment hidden (obsolete)
Sam Weinig
Comment 6 2021-02-27 17:52:20 PST
Created attachment 421764 [details] Patch
Sam Weinig
Comment 7 2021-02-28 14:13:19 PST
The patch is essentially identical to the previous one which Darin reviewed with the following exceptions: - Disabled behind a ENABLE flag. - A little simpler due to no longer having the pixel/pos/css prefixes to deal with. - Has a bindings test. - Does not remove old, named getter/setter based code.
Sam Weinig
Comment 8 2021-02-28 17:00:08 PST
Looks like IDL preprocessing is maybe not a thing on windows :(. We really need to remove that port if no one is going to work on it :(
Sam Weinig
Comment 9 2021-02-28 17:01:17 PST
Maybe I can work around it by reversing the meaning of the ifdef?
Sam Weinig
Comment 10 2021-02-28 18:05:27 PST
Created attachment 421786 [details] Patch
EWS
Comment 11 2021-03-01 13:27:44 PST
Committed r273688: <https://commits.webkit.org/r273688> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421786 [details].
Radar WebKit Bug Importer
Comment 12 2021-03-01 13:28:15 PST
<rdar://problem/74887863>
Note You need to log in before you can comment on or make changes to this bug.