Bug 222497

Summary: Length blending should allow for a ValueRange parameter
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, graouts, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Antoine Quint
Reported 2021-02-26 15:01:01 PST
Length blending should allow for a ValueRange parameter
Attachments
Patch (5.44 KB, patch)
2021-02-26 15:05 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.43 KB, patch)
2021-02-26 15:49 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2021-02-26 15:05:52 PST
Created attachment 421711 [details] Patch
Dean Jackson
Comment 2 2021-02-26 15:29:44 PST
Comment on attachment 421711 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421711&action=review > Source/WebCore/ChangeLog:11 > + blend() override implementation which would disallow negative values. However, this is something that > + should ideally be provided lower down in the blending code in the blend() function provided by the > + Length type itself. This will allow us to blend other non-negative length-related types, such as The sentence starting with However has too many "provided"s.
Antoine Quint
Comment 3 2021-02-26 15:49:32 PST
Created attachment 421718 [details] Patch for landing
EWS
Comment 4 2021-02-26 16:29:32 PST
Committed r273603: <https://commits.webkit.org/r273603> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421718 [details].
Radar WebKit Bug Importer
Comment 5 2021-02-26 16:30:16 PST
<rdar://problem/74813273>
Note You need to log in before you can comment on or make changes to this bug.