Bug 222487

Summary:

[webkitcorepy] Move credential access from webkitscmpy

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Jonathan Bedard

Reported 2021-02-26 12:19:01 PST

I found myself duplicating the logic in GitHub.credentials(), clearly this logic should be generalized.

Attachments
Patch (12.99 KB, patch) 2021-02-26 12:21 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch for landing (12.99 KB, patch) 2021-02-26 13:11 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-02-26 12:19:13 PST

Jonathan Bedard

Comment 2 2021-02-26 12:21:43 PST

Aakash Jain

Comment 3 2021-02-26 12:44:44 PST

rs=me

Jonathan Bedard

Comment 4 2021-02-26 13:11:46 PST

Created attachment 421702 [details] Patch for landing

EWS

Comment 5 2021-02-26 13:36:30 PST

Committed r273585: <https://commits.webkit.org/r273585> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421702 [details].

Note You need to log in before you can comment on or make changes to this bug.