Bug 222487 - [webkitcorepy] Move credential access from webkitscmpy
Summary: [webkitcorepy] Move credential access from webkitscmpy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-26 12:19 PST by Jonathan Bedard
Modified: 2021-02-26 13:36 PST (History)
2 users (show)

See Also:

Attachments
Patch (12.99 KB, patch)
2021-02-26 12:21 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (12.99 KB, patch)
2021-02-26 13:11 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-02-26 12:19:01 PST 
I found myself duplicating the logic in GitHub.credentials(), clearly this logic should be generalized.
Comment 1 Radar WebKit Bug Importer 2021-02-26 12:19:13 PST 
<rdar://problem/74801487>
Comment 2 Jonathan Bedard 2021-02-26 12:21:43 PST 
Created attachment 421693 [details]
Patch
Comment 3 Aakash Jain 2021-02-26 12:44:44 PST 
rs=me
Comment 4 Jonathan Bedard 2021-02-26 13:11:46 PST 
Created attachment 421702 [details]
Patch for landing
Comment 5 EWS 2021-02-26 13:36:30 PST 
Committed r273585: <https://commits.webkit.org/r273585>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421702 [details].