Bug 222482

Summary: [git-webkit] Better error message when attempting to convert tag to identifier
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2021-02-26 10:54:28 PST
Aakash pointed to a case where we attempted to compute an identifier for a revision that matched a tag, which doesn't work. We should improve logging in this case: https://build.webkit.org/#/builders/66/builds/541
Attachments
Patch (2.68 KB, patch)
2021-02-26 10:56 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.62 KB, patch)
2021-03-02 16:10 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-02-26 10:55:02 PST
<rdar://problem/74797495>
Jonathan Bedard
Comment 2 2021-02-26 10:56:49 PST
Created attachment 421676 [details] Patch
Aakash Jain
Comment 3 2021-02-26 11:01:59 PST
Comment on attachment 421676 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421676&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:213 > raise self.Exception("Failed to find '{}' on '{}'".format(revision, branch)) This line can be re-worded something like: "Failed to find 'r{}' on branch: '{}'"
Jonathan Bedard
Comment 4 2021-03-02 16:10:54 PST
Created attachment 422015 [details] Patch for landing
EWS
Comment 5 2021-03-02 16:56:45 PST
Committed r273774: <https://commits.webkit.org/r273774> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422015 [details].
Note You need to log in before you can comment on or make changes to this bug.