Bug 222474 – [Cocoa] Send QOS parameters as part of Web process creation parameters

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Per Arne Vollan]

In order to save one IPC call when starting a WebContent process, send QOS parameters as part of Web process creation parameters.

[Per Arne Vollan]

Created attachment 421655 [details]
Patch

[Chris Dumez]

Comment on attachment 421655 [details]
Patch

r=me

[Chris Dumez]

Comment on attachment 421655 [details]
Patch

cq- because I believe you can drop the WebProcess::SetQOS IPC message entirely now. I don't see you updating WebProcess.messages.in in this patch.

[Brent Fulgham]

Comment on attachment 421655 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421655&action=review

r=me

> Source/WebKit/UIProcess/WebProcessPool.cpp:-857
> -    process.send(Messages::WebProcess::SetQOS(webProcessLatencyQOS(), webProcessThroughputQOS()), 0);

This appears to be the only use of this WebProcess message. I suggest we remove the message declaration in WebProcess.messages.in, too.

[Brent Fulgham]

(In reply to Chris Dumez from comment #3)
> Comment on attachment 421655 [details]
> Patch
> 
> cq- because I believe you can drop the WebProcess::SetQOS IPC message
> entirely now. I don't see you updating WebProcess.messages.in in this patch.

Ha! I was making the same comment!

[Per Arne Vollan]

Will fix!

Thanks for reviewing, all!

[Per Arne Vollan]

Created attachment 421672 [details]
Patch

[EWS]

Committed r273576: <https://commits.webkit.org/r273576>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421672 [details].

[Radar WebKit Bug Importer]

<rdar://problem/74801679>