Bug 22246

Summary: Get arguments for opcodes together to eliminate more redundant memory reads
Product: WebKit Reporter: Cameron Zwarich (cpst) <zwarich>
Component: JavaScriptCoreAssignee: Cameron Zwarich (cpst) <zwarich>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch darin: review+

Cameron Zwarich (cpst)
Reported 2008-11-13 16:20:49 PST
Currently, if an opcode gets its first operand in eax and its second operand in edx, the read from eax will kill the last result register. Instead, if there is an opportunity for optimization for the second operand we should move eax to edx and then read the first operand from memory into eax.
Attachments
Proposed patch (11.59 KB, patch)
2008-11-13 16:29 PST, Cameron Zwarich (cpst) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Cameron Zwarich (cpst)
Comment 1 2008-11-13 16:29:59 PST
Created attachment 25142 [details] Proposed patch
Darin Adler
Comment 2 2008-11-13 16:33:39 PST
Comment on attachment 25142 [details] Proposed patch r=me
Cameron Zwarich (cpst)
Comment 3 2008-11-13 17:40:30 PST
Landed in r38379.
Note You need to log in before you can comment on or make changes to this bug.