Bug 222458

Summary: Fix crashes due to unsupported pixel formats, program generation issues in Metal Angle backend on Simulator
Product: WebKit Reporter: Kyle Piddington <kpiddington>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, graouts, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Kyle Piddington
Reported 2021-02-25 21:38:02 PST
Fix crashes due to unsupported pixel formats, program generation issues in Metal Angle backend on Simulator
Attachments
Patch (216.46 KB, patch)
2021-02-25 21:38 PST, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Patch (218.36 KB, patch)
2021-02-26 01:40 PST, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Patch (239.33 KB, patch)
2021-02-26 11:57 PST, Kyle Piddington 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (239.50 KB, patch)
2021-02-26 12:35 PST, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Patch (238.00 KB, patch)
2021-02-26 16:46 PST, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Kyle Piddington
Comment 1 2021-02-25 21:38:49 PST
Created attachment 421607 [details] Patch
EWS Watchlist
Comment 2 2021-02-25 21:39:53 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Kyle Piddington
Comment 3 2021-02-26 01:40:19 PST
Created attachment 421624 [details] Patch
Kyle Piddington
Comment 4 2021-02-26 11:57:28 PST
Created attachment 421688 [details] Patch
Kyle Piddington
Comment 5 2021-02-26 12:35:48 PST
Created attachment 421697 [details] Patch
Dean Jackson
Comment 6 2021-02-26 15:27:25 PST
Comment on attachment 421697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421697&action=review > Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/xcshareddata/xcschemes/WebKitTestRunner.xcscheme:38 > + launchStyle = "1" > useCustomWorkingDirectory = "NO" Oops. I'll remove this on landing.
Dean Jackson
Comment 7 2021-02-26 15:46:40 PST
Committed r273597 (234647@main): <https://commits.webkit.org/234647@main>
Radar WebKit Bug Importer
Comment 8 2021-02-26 15:47:16 PST
<rdar://problem/74811255>
Kyle Piddington
Comment 9 2021-02-26 16:46:38 PST
Reopening to attach new patch.
Kyle Piddington
Comment 10 2021-02-26 16:46:39 PST
Created attachment 421727 [details] Patch
Kyle Piddington
Comment 11 2021-02-26 16:53:17 PST
Accidentally reopen'd, Dean forgot to mention this was landed. Committed r273597 (234647@main): <https://commits.webkit.org/234647@main>
Note You need to log in before you can comment on or make changes to this bug.