Bug 222443

Summary: [resultsdbpy] Use webkitcorepy requests mocking
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dewei_zhu, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2021-02-25 15:52:24 PST
resultsdbpy should not duplicate requests mocking logic. This is also important because the logic defined in webkitcorepy can be stacked, while the mock structures used in resultsdbpy testing cannot be.
Attachments
Patch (13.91 KB, patch)
2021-02-25 15:56 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-02-25 15:52:52 PST
<rdar://problem/74764567>
Jonathan Bedard
Comment 2 2021-02-25 15:56:25 PST
Created attachment 421579 [details] Patch
EWS
Comment 3 2021-02-26 13:03:58 PST
Committed r273584: <https://commits.webkit.org/r273584> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421579 [details].
Note You need to log in before you can comment on or make changes to this bug.