Bug 222413

Summary: [GTK][WPE] Bump libsoup3 version to 2.99.1
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, benjamin, berto, bugs-noreply, cdumez, cmarcelo, ews-watchlist, gustavo, gyuyoung.kim, ryuan.choi, sergio
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 220508    
Attachments:
Description Flags
Patch aperez: review+, aperez: commit-queue-

Carlos Garcia Campos
Reported 2021-02-25 04:48:04 PST
.
Attachments
Patch (6.91 KB, patch)
2021-02-25 04:50 PST, Carlos Garcia Campos 		aperez: review+
aperez: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2021-02-25 04:50:12 PST
Created attachment 421515 [details] Patch
Adrian Perez
Comment 2 2021-02-26 01:33:05 PST
Comment on attachment 421515 [details] Patch LGTM with a nit and a comment :) View in context: https://bugs.webkit.org/attachment.cgi?id=421515&action=review > Source/WebCore/ChangeLog:8 > + Use new session getters and setters instead og g_object_get/set. Typo: og → of > Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:113 > + m_soupSession = adoptGRef(soup_session_new_with_options( I guess the idea to move the initialization of “m_soupSession” here was because now it's longer but I don't see any other reason to not keep using the constructor initializer list syntax (and also not needing to move the “maxConnections” and “maxConnectionsPerHost” constants, I guess?) In this case it's not much of an issue because a GRefPtr<> is cheap to construct with the default value, then assign to it inside the constructor body, so feel free to land as-is =)
Carlos Garcia Campos
Comment 3 2021-02-26 01:39:43 PST
Committed r273545 (234608@main): <https://commits.webkit.org/234608@main>
Note You need to log in before you can comment on or make changes to this bug.