Bug 222404

Summary: Optimize the code to check if an element delegates focus to its shadow root or not
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED WONTFIX    
Severity: Normal CC: cdumez, cmarcelo, commit-queue, esprehn+autocc, ews-watchlist, kangil.han, koivisto, simon.fraser, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 222510    
Bug Blocks: 222159    
Attachments:
Description Flags
Patch none

Ryosuke Niwa
Reported 2021-02-24 22:20:12 PST
Split from the bug 222159.
Attachments
Patch (5.24 KB, patch)
2021-02-24 22:36 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2021-02-24 22:20:49 PST
<rdar://problem/74680265>
Ryosuke Niwa
Comment 2 2021-02-24 22:36:09 PST
Created attachment 421502 [details] Patch
Simon Fraser (smfr)
Comment 3 2021-02-24 22:38:34 PST
Comment on attachment 421502 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421502&action=review > Source/WebCore/dom/Node.h:554 > + DelegatesFocusToShadowRoot = 1 << 27, If a node DelegatesFocusToShadowRoot, does it already have rare data? If so, could we put this bit in rare data?
Ryosuke Niwa
Comment 4 2021-02-24 22:39:31 PST
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 421502 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=421502&action=review > > > Source/WebCore/dom/Node.h:554 > > + DelegatesFocusToShadowRoot = 1 << 27, > > If a node DelegatesFocusToShadowRoot, does it already have rare data? If so, > could we put this bit in rare data? The point of this optimization is to avoid retrieving the rare data.
Ryosuke Niwa
Comment 5 2021-02-24 22:50:59 PST
Comment on attachment 421502 [details] Patch Clearing flags on attachment: 421502 Committed r273474 (234554@main): <https://commits.webkit.org/234554@main>
Ryosuke Niwa
Comment 6 2021-02-24 22:51:01 PST
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 7 2021-02-27 01:27:26 PST
Re-opened since this is blocked by bug 222510
Ryosuke Niwa
Comment 8 2021-02-27 01:32:10 PST
This was not an overall speed up after all.
Note You need to log in before you can comment on or make changes to this bug.