Summary: | Avoid setting page muted state if unchanged | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||
Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, dean_johnson, eric.carlson, jer.noble, simon.fraser, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Per Arne Vollan
2021-02-24 17:44:04 PST
Created attachment 421489 [details]
Patch
Comment on attachment 421489 [details]
Patch
Silly we didn't do this before! r=me.
Comment on attachment 421489 [details]
Patch
Thanks for reviewing!
Committed r273499: <https://commits.webkit.org/r273499> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421489 [details]. Comment on attachment 421489 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421489&action=review > Source/WebCore/ChangeLog:8 > + Return early in Page::setMuted if muted state did not change. Why? (In reply to Simon Fraser (smfr) from comment #6) > Comment on attachment 421489 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=421489&action=review > > > Source/WebCore/ChangeLog:8 > > + Return early in Page::setMuted if muted state did not change. > > Why? This is to avoid work when creating the Web page in WP, and should be a small speedup. Thanks for reviewing! (In reply to Per Arne Vollan from comment #7) > (In reply to Simon Fraser (smfr) from comment #6) > > Comment on attachment 421489 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=421489&action=review > > > > > Source/WebCore/ChangeLog:8 > > > + Return early in Page::setMuted if muted state did not change. > > > > Why? > > This is to avoid work when creating the Web page in WP, and should be a > small speedup. > > Thanks for reviewing! The changelog should have said that. Is there an associated radar? (In reply to Simon Fraser (smfr) from comment #8) > (In reply to Per Arne Vollan from comment #7) > > (In reply to Simon Fraser (smfr) from comment #6) > > > Comment on attachment 421489 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=421489&action=review > > > > > > > Source/WebCore/ChangeLog:8 > > > > + Return early in Page::setMuted if muted state did not change. > > > > > > Why? > > > > This is to avoid work when creating the Web page in WP, and should be a > > small speedup. > > > > Thanks for reviewing! > > The changelog should have said that. Is there an associated radar? Yes, I agree, that change log entry was too short. This is the radar: <rdar://problem/74754341> |