Bug 22238

Summary: Avoid unnecessary reads of temporaries when the target machine register is not eax
Product: WebKit Reporter: Cameron Zwarich (cpst) <zwarich>
Component: JavaScriptCoreAssignee: Cameron Zwarich (cpst) <zwarich>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch darin: review+

Cameron Zwarich (cpst)
Reported 2008-11-13 13:49:32 PST
Currently we don't apply the optimization of not reading a value back from memory that we just wrote when the target machine register is not eax. A few opcodes will read into edx and not read into eax. In these cases we could just do a register-register move.
Attachments
Proposed patch (deleted)
2008-11-13 14:04 PST, Cameron Zwarich (cpst) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Cameron Zwarich (cpst)
Comment 1 2008-11-13 14:04:14 PST
Created attachment 25134 [details] Proposed patch
Darin Adler
Comment 2 2008-11-13 14:09:08 PST
Comment on attachment 25134 [details] Proposed patch r=me
Cameron Zwarich (cpst)
Comment 3 2008-11-19 13:08:35 PST
Landed in r38377.
Note You need to log in before you can comment on or make changes to this bug.