Bug 222348

Summary:

[GPU Process] Implement ImageBufferShareableBitmapBackend::bytesPerRow()

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

Canvas

Assignee:

Said Abou-Hallawa <sabouhallawa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Said Abou-Hallawa 2021-02-24 01:42:15 PST

The ShareableBitmapCG aligns the rows using IOSurfaceAlignProperty(kIOSurfaceBytesPerRow, ...). This means the default implementation which is "width x 4" is wrong for ImageBufferShareableBitmapBackend.

This will fix the layout failure:

fast/canvas/canvas-large-dimensions.html [ Failure ]

Comment 1 Said Abou-Hallawa 2021-02-24 01:46:08 PST

Created attachment 421390 [details]
Patch

Comment 2 EWS 2021-02-24 09:52:01 PST

Committed r273406: <https://commits.webkit.org/r273406>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421390 [details].

Comment 3 Radar WebKit Bug Importer 2021-02-24 09:53:19 PST

<rdar://problem/74700179>