Bug 222341

Summary: [GPU Process] Tests under imported/blink/fast/canvas are now fixed by r273956
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: CanvasAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Said Abou-Hallawa
Reported 2021-02-23 19:29:17 PST
This causes the failures in these tests: imported/blink/fast/canvas/canvas-clip-stack-persistence.html [ ImageOnlyFailure ] imported/blink/fast/canvas/canvas-state-persistence-no-dirty.html [ ImageOnlyFailure ] imported/blink/fast/canvas/canvas-unbalanced-save.html [ ImageOnlyFailure ]
Attachments
Patch (3.78 KB, patch)
2021-02-23 20:40 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (4.20 KB, patch)
2021-02-24 10:55 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (1.60 KB, patch)
2021-03-05 23:16 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2021-02-23 20:40:23 PST
Created attachment 421382 [details] Patch
Said Abou-Hallawa
Comment 2 2021-02-24 10:55:50 PST
Created attachment 421428 [details] Patch
Radar WebKit Bug Importer
Comment 3 2021-03-02 19:30:16 PST
<rdar://problem/74964300>
Simon Fraser (smfr)
Comment 4 2021-03-04 10:52:13 PST
Comment on attachment 421428 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421428&action=review > Source/WebCore/ChangeLog:8 > + This is not the ultimate solution. But flushDrawingContext() has a bug What is the flushDrawingContext() bug?
Said Abou-Hallawa
Comment 5 2021-03-05 23:12:48 PST
Comment on attachment 421428 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421428&action=review >> Source/WebCore/ChangeLog:8 >> + This is not the ultimate solution. But flushDrawingContext() has a bug > > What is the flushDrawingContext() bug? I was wrong about flushDrawingContext(). I thought there is a synchronization bug with replaying back the DisplayList items in GPUP and getting the NativeImage of the IOSurface in WebP. It turned out it is a 2D canvas compositing issue which was fixed by r273956
Said Abou-Hallawa
Comment 6 2021-03-05 23:16:09 PST
Created attachment 422475 [details] Patch
Said Abou-Hallawa
Comment 7 2021-03-05 23:17:29 PST
I am going to r+ and cq+ this patch since it is just test gardening only.
EWS
Comment 8 2021-03-05 23:52:46 PST
Committed r274032: <https://commits.webkit.org/r274032> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422475 [details].
Note You need to log in before you can comment on or make changes to this bug.