Bug 222330

Summary:

[iOS] Reduce use of retain/release in WAKWindow and remove unneeded methods from that class

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

WebKit Misc.

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, sam, tsavell, webkit-bug-importer

Priority:

P2

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

iPhone / iPad

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Darin Adler

Reported 2021-02-23 13:19:12 PST

Reduce use of retain/release in WAKWindow and remove unneeded methods from that class

Attachments
Patch (23.53 KB, patch) 2021-02-23 15:46 PST, Darin Adler	no flags	Details Formatted Diff Diff
Patch (24.35 KB, patch) 2021-02-23 17:29 PST, Darin Adler	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2021-02-23 15:46:39 PST

Created attachment 421360 [details] Patch

Darin Adler

Comment 2 2021-02-23 17:29:47 PST

Created attachment 421378 [details] Patch

Chris Dumez

Comment 3 2021-02-23 18:27:26 PST

Comment on attachment 421378 [details] Patch r=me

Chris Dumez

Comment 4 2021-02-24 16:35:48 PST

Ready to cq+?

Darin Adler

Comment 5 2021-02-24 17:03:48 PST

I had missed your r=me!

Darin Adler

Comment 6 2021-02-24 17:06:06 PST

Committed r273462 (234543@main): <https://commits.webkit.org/234543@main>

Radar WebKit Bug Importer

Comment 7 2021-02-24 17:07:20 PST

<rdar://problem/74721444>

Truitt Savell

Comment 8 2021-02-25 09:34:31 PST

Reverted r273462 for reason: Caused API build failures Committed r273489 (234568@main): <https://commits.webkit.org/234568@main>

Darin Adler

Comment 9 2021-02-25 10:26:08 PST

Will re-land this once we fix the header dependences in Apple’s internal build system.

EWS

Comment 10 2021-02-28 12:56:45 PST

Committed r273639: <https://commits.webkit.org/r273639> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421378 [details].

Note You need to log in before you can comment on or make changes to this bug.