Bug 222325

Summary: Cloop JSC test driver command shouldn't pass build flags
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, angelos, darin, ews-watchlist, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 221186    
Attachments:
Description Flags
Patch none

Keith Miller
Reported 2021-02-23 11:01:49 PST
Cloop JSC test driver command shouldn't pass build flags
Attachments
Patch (1.31 KB, patch)
2021-02-23 11:02 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2021-02-23 11:02:43 PST
Created attachment 421331 [details] Patch
Ryan Haddad
Comment 2 2021-02-23 11:08:38 PST
*** Bug 222321 has been marked as a duplicate of this bug. ***
Aakash Jain
Comment 3 2021-02-23 11:30:08 PST
How do we know it is unused? It seems to be passed in https://build.webkit.org/#/builders/39/builds/520/steps/8/logs/stdio If the script ignores this parameter, can we delete this parameter completely from build-jsc (e.g.: https://github.com/WebKit/WebKit/blob/main/Tools/Scripts/build-jsc#L89)
Keith Miller
Comment 4 2021-02-23 12:46:23 PST
(In reply to Aakash Jain from comment #3) > How do we know it is unused? > It seems to be passed in > https://build.webkit.org/#/builders/39/builds/520/steps/8/logs/stdio Because we are passing --no-build and that's a build flag. AFAIK, no test uses it. > > If the script ignores this parameter, can we delete this parameter > completely from build-jsc (e.g.: > https://github.com/WebKit/WebKit/blob/main/Tools/Scripts/build-jsc#L89) We want it when we don't pass --no-build so we trigger a build with CLoop.
Angelos Oikonomopoulos
Comment 5 2021-02-24 02:09:59 PST
(In reply to Keith Miller from comment #4) > (In reply to Aakash Jain from comment #3) > > How do we know it is unused? > > It seems to be passed in > > https://build.webkit.org/#/builders/39/builds/520/steps/8/logs/stdio > > Because we are passing --no-build and that's a build flag. AFAIK, no test > uses it. No test can ever see it. As --cloop is not recognized by run-javascriptcore-tests (and because we use Getopt::Long qw(:config pass_through)), it ends up in @ARGV after argument parsing. @ARGV is only used in the RHS of an assignment to @buildArgs, which is only ever used if $buildJSC is true. So --cloop is ignored when passing in --no-build to run-javascriptcore-tests (see also #221186).
Aakash Jain
Comment 6 2021-02-24 03:39:38 PST
ok. sounds good.
EWS
Comment 7 2021-02-24 11:10:51 PST
Committed r273410: <https://commits.webkit.org/r273410> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421331 [details].
Radar WebKit Bug Importer
Comment 8 2021-02-24 11:12:07 PST
<rdar://problem/74704402>
Note You need to log in before you can comment on or make changes to this bug.