Bug 222284

Summary: [Cocoa] Send sandbox extensions for Network Extension services in load parameters
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
bfulgham: review+
Patch
ews-feeder: commit-queue-
Patch none

Per Arne Vollan
Reported 2021-02-22 12:28:38 PST
Currently, sandbox extensions for Network Extension are sent from the UI process to the WebContent process when the policy decision is made, but that is not soon enough in all cases. They should also be sent as part of the load parameters.
Attachments
Patch (4.25 KB, patch)
2021-02-22 12:33 PST, Per Arne Vollan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch (4.79 KB, patch)
2021-02-22 13:28 PST, Per Arne Vollan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (4.24 KB, patch)
2021-02-22 13:29 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2021-02-22 12:30:48 PST
<rdar://problem/74402532>
Per Arne Vollan
Comment 2 2021-02-22 12:33:20 PST
Created attachment 421226 [details] Patch
Brent Fulgham
Comment 3 2021-02-22 12:34:48 PST
Comment on attachment 421226 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421226&action=review r=me > Source/WebKit/ChangeLog:10 > + policy decision is made, but that is not soon enough in all cases. They should also be sent as part of the load parameters. Should we remove the policy decision part, since we are doing it at load time now?
Per Arne Vollan
Comment 4 2021-02-22 13:28:12 PST
Created attachment 421233 [details] Patch
Per Arne Vollan
Comment 5 2021-02-22 13:29:16 PST
Created attachment 421234 [details] Patch
Per Arne Vollan
Comment 6 2021-02-22 13:30:51 PST
(In reply to Brent Fulgham from comment #3) > Comment on attachment 421226 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=421226&action=review > > r=me > > > Source/WebKit/ChangeLog:10 > > + policy decision is made, but that is not soon enough in all cases. They should also be sent as part of the load parameters. > > Should we remove the policy decision part, since we are doing it at load > time now? I believe this is still needed, since the order of events can vary. Thanks for reviewing!
EWS
Comment 7 2021-02-22 16:03:13 PST
Committed r273286: <https://commits.webkit.org/r273286> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421234 [details].
Note You need to log in before you can comment on or make changes to this bug.