Bug 222275

Summary:

REGRESSION(r273204): webkitpy tests fail

Product:

WebKit

Reporter:

Sam Sneddon [:gsnedders] <gsnedders>

Component:

Tools / Tests

Assignee:

Kimmo Kinnunen <kkinnunen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ggaren, jbedard, kkinnunen, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=219641

Attachments:

Description	Flags
Patch	none

Description Sam Sneddon [:gsnedders] 2021-02-22 09:37:40 PST

Looking at Python 2 below, as Python 3 fails to run tests at all due to Bug 222274; after that has landed this should track making both Python 2 and Python 3 pass tests again.

gsnedders@gsnedders-milk OpenSource % ./Tools/Scripts/test-webkitpy-python2 -j1 -p Source/WebKit/Scripts/webkit/messages_unittest.py
Suppressing most webkitpy logging while running unit tests.
Running the tests ...In expected file /Volumes/gsnedders/projects/Safari/OpenSource/Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp
[1/3] webkit.messages_unittest.GeneratedFileContentsTest.test_message_argument_description failed:
  Traceback (most recent call last):
    File "/Volumes/gsnedders/projects/Safari/OpenSource/Source/WebKit/Scripts/webkit/messages_unittest.py", line 109, in test_message_argument_description
      self.assertGeneratedFileContentsEqual(implementation_contents, os.path.join(tests_directory, 'MessageArgumentDescriptions.cpp'))
    File "/Volumes/gsnedders/projects/Safari/OpenSource/Source/WebKit/Scripts/webkit/messages_unittest.py", line 86, in assertGeneratedFileContentsEqual
      self.assertEquals(actual_line, expected_line_list[index])
  AssertionError: '#include "StreamConnectionBuffer.h"' != '#include "TestClassName.h"'
  
In expected file /Volumes/gsnedders/projects/Safari/OpenSource/Source/WebKit/Scripts/webkit/tests/MessageNames.h
[2/3] webkit.messages_unittest.GeneratedFileContentsTest.test_message_names failed:
  Traceback (most recent call last):
    File "/Volumes/gsnedders/projects/Safari/OpenSource/Source/WebKit/Scripts/webkit/messages_unittest.py", line 102, in test_message_names
      self.assertGeneratedFileContentsEqual(header_contents, os.path.join(tests_directory, 'MessageNames.h'))
    File "/Volumes/gsnedders/projects/Safari/OpenSource/Source/WebKit/Scripts/webkit/messages_unittest.py", line 86, in assertGeneratedFileContentsEqual
      self.assertEquals(actual_line, expected_line_list[index])
  AssertionError: '    , TestWithStream = 5' != '    , TestWithSuperclass = 5'
  
In expected file /Volumes/gsnedders/projects/Safari/OpenSource/Source/WebKit/Scripts/webkit/tests/TestWithSemaphoreMessages.h
[3/3] webkit.messages_unittest.GeneratedFileContentsTest.test_receiver failed:
  Traceback (most recent call last):
    File "/Volumes/gsnedders/projects/Safari/OpenSource/Source/WebKit/Scripts/webkit/messages_unittest.py", line 96, in test_receiver
      self.assertGeneratedFileContentsEqual(header_contents, os.path.join(tests_directory, '{}Messages.h'.format(receiver_name)))
    File "/Volumes/gsnedders/projects/Safari/OpenSource/Source/WebKit/Scripts/webkit/messages_unittest.py", line 86, in assertGeneratedFileContentsEqual
      self.assertEquals(actual_line, expected_line_list[index])
  AssertionError: '#include "IPCSemaphore.h"' != '#include "MessageNames.h"'
  
Ran 3 tests in 0.038s
FAILED (failures=3, errors=0)

Comment 1 Radar WebKit Bug Importer 2021-02-22 14:36:47 PST

<rdar://problem/74614397>

Comment 2 Kimmo Kinnunen 2021-02-23 01:03:33 PST

Created attachment 421289 [details]
Patch

Comment 3 EWS 2021-02-23 09:37:58 PST

Committed r273313: <https://commits.webkit.org/r273313>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421289 [details].