Bug 22223

Summary: REGRESSION(r38245): "View Source" crashes the browser
Product: WebKit Reporter: Thomas Sutton <thsutton>
Component: New BugsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Major CC: darin
Priority: P2 Keywords: InRadar, Regression
Version: 528+ (Nightly build)   
Hardware: Mac (PowerPC)   
OS: OS X 10.4   
Attachments:
Description Flags
Report of the view source crash none

Description Thomas Sutton 2008-11-12 16:57:24 PST
The latest nightly WebKit build downloaded as WebKit-SVN-r38297.dmg crashes whenever I use the View Source function, whether by menu or shortcut. This happens on multiple sites (including twitter.com and gardnermuseum.org).

Steps to reproduce on my PPC iMac with 10.4.11:

1) Open WebKit.app
2) Browse to a web page (it appears that any will do)
3) View Source through the menu bar or alt-cmd-u.
4) The browser crashes.
Comment 1 Thomas Sutton 2008-11-12 16:58:18 PST
Created attachment 25108 [details]
Report of the view source crash
Comment 2 Mark Rowe (bdash) 2008-11-12 17:48:47 PST
<rdar://problem/6366864>
Comment 3 Darin Adler 2008-11-12 18:01:39 PST
I can't reproduce this but it's clear it's trivial to fix. Just need to null-check _private in viewDidMoveToWindow.
Comment 4 Darin Adler 2008-11-12 18:05:19 PST
http://trac.webkit.org/changeset/38355