Bug 222186

Summary:

[MotionMark] Make PaintTimingEnabled default to false

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

Layout and Rendering

Assignee:

Said Abou-Hallawa <sabouhallawa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, noam, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=211736
https://bugs.webkit.org/show_bug.cgi?id=208499
https://bugs.webkit.org/show_bug.cgi?id=222245
https://bugs.webkit.org/show_bug.cgi?id=222250

Attachments:

Description	Flags
Patch	none

Description Said Abou-Hallawa 2021-02-19 11:53:49 PST

PaintTiming causes about 4% regression in the MotionMark sub-tests: Multiply and Focus. Do disable it for now.

Comment 1 Said Abou-Hallawa 2021-02-19 11:54:35 PST

<rdar://problem/73416302>

Comment 2 Said Abou-Hallawa 2021-02-19 11:57:31 PST

Created attachment 421004 [details]
Patch

Comment 3 EWS 2021-02-20 14:43:44 PST

Committed r273207: <https://commits.webkit.org/r273207>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421004 [details].

Comment 4 Noam Rosenthal 2021-02-21 11:15:45 PST

I believe that the root cause is fixed here: https://trac.webkit.org/changeset/273220/webkit

I don't have the means to test the effect on MotionMark result, as locally it doesn't produce consistent results for me.

Said, Can you or someone else with access to the consistent testing environment help make sure that this is true and perhaps revert this patch?

Thanks!

Comment 5 Simon Fraser (smfr) 2021-02-21 11:53:55 PST

Re-enabling via bug 222250.