Bug 222186

Summary: [MotionMark] Make PaintTimingEnabled default to false
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: Layout and RenderingAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, noam, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=211736
https://bugs.webkit.org/show_bug.cgi?id=208499
https://bugs.webkit.org/show_bug.cgi?id=222245
https://bugs.webkit.org/show_bug.cgi?id=222250
Attachments:
Description Flags
Patch none

Said Abou-Hallawa
Reported 2021-02-19 11:53:49 PST
PaintTiming causes about 4% regression in the MotionMark sub-tests: Multiply and Focus. Do disable it for now.
Attachments
Patch (1.30 KB, patch)
2021-02-19 11:57 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2021-02-19 11:54:35 PST
<rdar://problem/73416302>
Said Abou-Hallawa
Comment 2 2021-02-19 11:57:31 PST
Created attachment 421004 [details] Patch
EWS
Comment 3 2021-02-20 14:43:44 PST
Committed r273207: <https://commits.webkit.org/r273207> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421004 [details].
Noam Rosenthal
Comment 4 2021-02-21 11:15:45 PST
I believe that the root cause is fixed here: https://trac.webkit.org/changeset/273220/webkit I don't have the means to test the effect on MotionMark result, as locally it doesn't produce consistent results for me. Said, Can you or someone else with access to the consistent testing environment help make sure that this is true and perhaps revert this patch? Thanks!
Simon Fraser (smfr)
Comment 5 2021-02-21 11:53:55 PST
Re-enabling via bug 222250.
Note You need to log in before you can comment on or make changes to this bug.