Bug 222162

Summary: [JSC] Remove vm.topCallFrame storing in Baseline JIT
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Description Yusuke Suzuki 2021-02-19 00:31:57 PST
[JSC] Remove vm.topCallFrame storing in Baseline JIT
Comment 1 Yusuke Suzuki 2021-02-19 00:40:16 PST
Created attachment 420935 [details]
Patch
Comment 2 Mark Lam 2021-02-19 01:06:23 PST
Comment on attachment 420935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420935&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        This patch removes vm.topCallFrame storing in Baseline JIT since operation / slow-path-call can retrieve CallFrame* via
> +        __builtin_frame_address or callFrame argument.

After discussing the intent of this patch with Yusuke offline, I suggest rephrasing this as "This patch removes vm.topCallFrame storing in the Baseline JIT for ports that can USE(BUILTIN_FRAME_ADDRESS).  Also refactored some CommonSlowPath functions so that they can start using __builtin_frame_address later instead of the requiring that CallFrame be passed in."
Comment 3 Mark Lam 2021-02-19 01:06:32 PST
r=me
Comment 4 Mark Lam 2021-02-19 01:29:48 PST
(In reply to Mark Lam from comment #2)
> After discussing the intent of this patch with Yusuke offline, I suggest
> rephrasing this as "This patch removes vm.topCallFrame storing in the
> Baseline JIT for ports that can USE(BUILTIN_FRAME_ADDRESS).  Also refactored
> some CommonSlowPath functions so that they can start using
> __builtin_frame_address later instead of the requiring that CallFrame be
> passed in."

Looks like I had a typo:

/instead of the requiring/instead of requiring/
Comment 5 Yusuke Suzuki 2021-02-21 04:37:47 PST
Committed r273217 (234403@main): <https://commits.webkit.org/234403@main>
Comment 6 Radar WebKit Bug Importer 2021-02-21 04:38:16 PST
<rdar://problem/74566597>