Summary: | [JSC] Remove vm.topCallFrame storing in Baseline JIT | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Yusuke Suzuki
2021-02-19 00:31:57 PST
Created attachment 420935 [details]
Patch
Comment on attachment 420935 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420935&action=review > Source/JavaScriptCore/ChangeLog:9 > + This patch removes vm.topCallFrame storing in Baseline JIT since operation / slow-path-call can retrieve CallFrame* via > + __builtin_frame_address or callFrame argument. After discussing the intent of this patch with Yusuke offline, I suggest rephrasing this as "This patch removes vm.topCallFrame storing in the Baseline JIT for ports that can USE(BUILTIN_FRAME_ADDRESS). Also refactored some CommonSlowPath functions so that they can start using __builtin_frame_address later instead of the requiring that CallFrame be passed in." r=me (In reply to Mark Lam from comment #2) > After discussing the intent of this patch with Yusuke offline, I suggest > rephrasing this as "This patch removes vm.topCallFrame storing in the > Baseline JIT for ports that can USE(BUILTIN_FRAME_ADDRESS). Also refactored > some CommonSlowPath functions so that they can start using > __builtin_frame_address later instead of the requiring that CallFrame be > passed in." Looks like I had a typo: /instead of the requiring/instead of requiring/ Committed r273217 (234403@main): <https://commits.webkit.org/234403@main> |