Bug 222151

Summary: Correctly retain properties in _WKAppHighlight
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch wenson_hsieh: review+

Megan Gardner
Reported 2021-02-18 17:58:43 PST
Correctly retain properties in _WKAppHighlight
Attachments
Patch (2.90 KB, patch)
2021-02-18 17:59 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (2.78 KB, patch)
2021-02-18 18:07 PST, Megan Gardner 		wenson_hsieh: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2021-02-18 17:59:45 PST
Created attachment 420891 [details] Patch
Wenson Hsieh
Comment 2 2021-02-18 18:05:29 PST
Comment on attachment 420891 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420891&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKAppHighlight.mm:45 > + _highlight = adoptNS(highlight); > + _text = adoptNS(text); > + _image = adoptNS(image); This will overrelease the arguments, since they're not +1 objects.
Megan Gardner
Comment 3 2021-02-18 18:07:22 PST
Created attachment 420893 [details] Patch
Megan Gardner
Comment 4 2021-02-18 18:18:22 PST
Committed r273119 (234316@main): <https://commits.webkit.org/234316@main>
Radar WebKit Bug Importer
Comment 5 2021-02-18 18:19:12 PST
<rdar://problem/74503732>
Note You need to log in before you can comment on or make changes to this bug.