| Summary: | Fix null dereferencing in RangeResponseGenerator::giveResponseToTasksWithFinishedRanges | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | darin | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=221072 | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2021-02-18 12:58:15 PST
Created attachment 420864 [details]
Patch
Comment on attachment 420864 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420864&action=review > Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm:274 > m_generator->giveResponseToTasksWithFinishedRanges(*data); I think it’s clearer to write: protectedThis->m_generator->giveResponseToTasksWithFinishedRanges(*data); But I’m not sure anyone else in this project agrees with me! Also, I think that Ryosuke said our overall strategy is to protect differently than this; it would be the caller who should be doing ref/deref, not this function protecting itself. So the fix would be in RemoteMediaResourceManager::loadFinished, which should be using a RefPtr for its local variable. Created attachment 420866 [details]
Patch
|