Bug 222111

Summary: Clean up ScrollableArea and ScrollAnimator API and convert less between offsets and positions
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: ScrollingAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 146696    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Martin Robinson
Reported 2021-02-18 08:59:06 PST
The ScrollableArea and ScrollAnimator API is a bit confusing when it comes to scrolling to offsets and positions. It isn't always clear when these APIs will trigger an animation and we are missing some opportunities to use "native" animations on Mac. These APIs also require a lot of conversion back and forth between offsets and positions. Finally, cleaning up this API will allow us to use native animations to do scroll snapping during thumb dragging.
Attachments
Patch (31.78 KB, patch)
2021-02-19 05:01 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (32.12 KB, patch)
2021-02-19 08:16 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (32.32 KB, patch)
2021-02-22 00:28 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2021-02-19 05:01:20 PST
Created attachment 420957 [details] Patch
Martin Robinson
Comment 2 2021-02-19 08:16:50 PST
Created attachment 420970 [details] Patch
Martin Robinson
Comment 3 2021-02-22 00:28:25 PST
Created attachment 421167 [details] Patch
EWS
Comment 4 2021-02-22 13:39:45 PST
Committed r273275: <https://commits.webkit.org/r273275> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421167 [details].
Radar WebKit Bug Importer
Comment 5 2021-02-22 13:40:15 PST
<rdar://problem/74611765>
Note You need to log in before you can comment on or make changes to this bug.