Bug 222099

Summary: RemoteRenderingBackend commands are not processed in order if GPU process is waiting for replies
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: CanvasAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, sabouhallawa, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
rebase none

Kimmo Kinnunen
Reported 2021-02-18 03:18:53 PST
RemoteRenderingBackend commands are not processed in order if GPU process is waiting for replies Asynchronous messages need to be sent with DispatchMessageEvenWhenWaitingForSyncReply in order for them to be dispatched in order with synchronous messages. Affects case where wait happens when RemoteRenderingBackend is created.
Attachments
Patch (8.87 KB, patch)
2021-02-18 03:31 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
rebase (8.91 KB, patch)
2021-03-15 03:30 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2021-02-18 03:31:51 PST
Created attachment 420820 [details] Patch
Radar WebKit Bug Importer
Comment 2 2021-02-25 03:19:13 PST
<rdar://problem/74738277>
Said Abou-Hallawa
Comment 3 2021-03-04 10:41:18 PST
Comment on attachment 420820 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420820&action=review > Source/WebKit/ChangeLog:22 > + If GPU process is waiting for a sync reply when the sequence up What are the synchronous messages which GPUP sends and waits for their replies?
Kimmo Kinnunen
Comment 4 2021-03-04 12:38:31 PST
(In reply to Said Abou-Hallawa from comment #3) > > Source/WebKit/ChangeLog:22 > > + If GPU process is waiting for a sync reply when the sequence up > > What are the synchronous messages which GPUP sends and waits for their > replies? I don't know enough of the codepaths to figure that out. I cannot see any in GPUProcess/ or Shared/, but it does not mean they don't happen today or in the future..
Kimmo Kinnunen
Comment 5 2021-03-15 03:30:41 PDT
Created attachment 423153 [details] rebase
EWS
Comment 6 2021-03-15 04:34:05 PDT
Committed r274413: <https://commits.webkit.org/r274413> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423153 [details].
Note You need to log in before you can comment on or make changes to this bug.