Bug 222089

Summary: Return correct target for App Highlight menus.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Megan Gardner
Reported 2021-02-17 19:25:34 PST
Return correct target for App Highlight menus.
Attachments
Patch (1.39 KB, patch)
2021-02-17 19:26 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (1.41 KB, patch)
2021-02-17 19:43 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.41 KB, patch)
2021-02-17 20:42 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2021-02-17 19:26:20 PST
Created attachment 420784 [details] Patch
Tim Horton
Comment 2 2021-02-17 19:35:06 PST
Comment on attachment 420784 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420784&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3699 > + if (sel_isEqual(action, @selector(createHighlightInCurrentGroupWithRange:)) || sel_isEqual(action, @selector(createHighlightInNewGroupWithRange:))) You can just use == (see above, or see the sel_isEqual docs)
Megan Gardner
Comment 3 2021-02-17 19:43:52 PST
Created attachment 420785 [details] Patch
Megan Gardner
Comment 4 2021-02-17 20:42:50 PST
Created attachment 420793 [details] Patch for landing
EWS
Comment 5 2021-02-17 23:59:29 PST
Committed r273066: <https://commits.webkit.org/r273066> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420793 [details].
Radar WebKit Bug Importer
Comment 6 2021-02-18 00:00:25 PST
<rdar://problem/74467567>
Note You need to log in before you can comment on or make changes to this bug.