Bug 222086

Summary: Adopt VM_FLAGS_PERMANENT for the config vm mapping
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, mark.lam, msaboff, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
patch
ews-feeder: commit-queue-
patch
ysuzuki: review+, ews-feeder: commit-queue-
patch for landing
ews-feeder: commit-queue-
patch for landing none

Saam Barati
Reported 2021-02-17 18:06:20 PST
...
Attachments
WIP (3.03 KB, patch)
2021-02-17 18:12 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (3.85 KB, patch)
2021-03-08 16:32 PST, Saam Barati 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch (3.84 KB, patch)
2021-03-08 16:54 PST, Saam Barati 		ysuzuki: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch for landing (5.22 KB, patch)
2021-03-09 12:04 PST, Saam Barati 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch for landing (6.39 KB, patch)
2021-03-11 14:42 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2021-02-17 18:08:13 PST
<rdar://74402690>
Saam Barati
Comment 2 2021-02-17 18:12:38 PST
Created attachment 420778 [details] WIP
Saam Barati
Comment 3 2021-03-08 16:32:09 PST
Created attachment 422634 [details] patch
Saam Barati
Comment 4 2021-03-08 16:54:22 PST
Created attachment 422639 [details] patch Try to fix the build error. I'll also look into the style error w.r.t my version checks.
Yusuke Suzuki
Comment 5 2021-03-08 17:04:28 PST
Comment on attachment 422639 [details] patch r=me
Saam Barati
Comment 6 2021-03-09 12:04:50 PST
Created attachment 422738 [details] patch for landing
Saam Barati
Comment 7 2021-03-11 14:42:48 PST
Created attachment 422973 [details] patch for landing Let's test EWS on this.
EWS
Comment 8 2021-03-11 21:44:00 PST
Committed r274325: <https://commits.webkit.org/r274325> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422973 [details].
Alex Christensen
Comment 9 2021-03-12 07:48:39 PST
Comment on attachment 422973 [details] patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=422973&action=review > Source/WTF/wtf/WTFConfig.cpp:75 > + RELEASE_ASSERT(result == KERN_SUCCESS); I'm hitting this assertion.
Alex Christensen
Comment 10 2021-03-12 09:15:09 PST
Never mind. Configuration issue on my part.
Alex Christensen
Comment 11 2021-05-18 13:54:40 PDT
Comment on attachment 422973 [details] patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=422973&action=review > Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:169 > + WTF::initializeMainThread(); This is too early. It causes SafariForWebKitDevelopment to crash because it calls a function from JavaScriptCore.framework before we have loaded the framework. What was the intent of adding this?
Alex Christensen
Comment 12 2021-05-18 14:20:45 PDT
Comment on attachment 422973 [details] patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=422973&action=review >> Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:169 >> + WTF::initializeMainThread(); > > This is too early. It causes SafariForWebKitDevelopment to crash because it calls a function from JavaScriptCore.framework before we have loaded the framework. What was the intent of adding this? Just kidding. It seems to work fine.
Note You need to log in before you can comment on or make changes to this bug.