Bug 222086

Summary: Adopt VM_FLAGS_PERMANENT for the config vm mapping
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, mark.lam, msaboff, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
patch
ews-feeder: commit-queue-
patch
ysuzuki: review+, ews-feeder: commit-queue-
patch for landing
ews-feeder: commit-queue-
patch for landing none

Description Saam Barati 2021-02-17 18:06:20 PST 
...
Comment 1 Saam Barati 2021-02-17 18:08:13 PST 
<rdar://74402690>
Comment 2 Saam Barati 2021-02-17 18:12:38 PST 
Created attachment 420778 [details]
WIP
Comment 3 Saam Barati 2021-03-08 16:32:09 PST 
Created attachment 422634 [details]
patch
Comment 4 Saam Barati 2021-03-08 16:54:22 PST 
Created attachment 422639 [details]
patch

Try to fix the build error.

I'll also look into the style error w.r.t my version checks.
Comment 5 Yusuke Suzuki 2021-03-08 17:04:28 PST 
Comment on attachment 422639 [details]
patch

r=me
Comment 6 Saam Barati 2021-03-09 12:04:50 PST 
Created attachment 422738 [details]
patch for landing
Comment 7 Saam Barati 2021-03-11 14:42:48 PST 
Created attachment 422973 [details]
patch for landing

Let's test EWS on this.
Comment 8 EWS 2021-03-11 21:44:00 PST 
Committed r274325: <https://commits.webkit.org/r274325>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422973 [details].
Comment 9 Alex Christensen 2021-03-12 07:48:39 PST 
Comment on attachment 422973 [details]
patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=422973&action=review

> Source/WTF/wtf/WTFConfig.cpp:75
> +        RELEASE_ASSERT(result == KERN_SUCCESS);

I'm hitting this assertion.
Comment 10 Alex Christensen 2021-03-12 09:15:09 PST 
Never mind.  Configuration issue on my part.
Comment 11 Alex Christensen 2021-05-18 13:54:40 PDT 
Comment on attachment 422973 [details]
patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=422973&action=review

> Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:169
> +    WTF::initializeMainThread();

This is too early.  It causes SafariForWebKitDevelopment to crash because it calls a function from JavaScriptCore.framework before we have loaded the framework.  What was the intent of adding this?
Comment 12 Alex Christensen 2021-05-18 14:20:45 PDT 
Comment on attachment 422973 [details]
patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=422973&action=review

>> Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:169
>> +    WTF::initializeMainThread();
> 
> This is too early.  It causes SafariForWebKitDevelopment to crash because it calls a function from JavaScriptCore.framework before we have loaded the framework.  What was the intent of adding this?

Just kidding.  It seems to work fine.